Page MenuHomeFreeBSD
Differential D9922

Fix a couple of typos and reword some sentences in bsd.README.
ClosedPublic
Actions

Authored by jhb on Mar 7 2017, 10:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 8:44 AM
Unknown Object (File)
Tue, Apr 23, 4:56 PM
Unknown Object (File)
Tue, Apr 9, 11:42 AM
Unknown Object (File)
Mon, Apr 8, 4:07 PM
Unknown Object (File)
Feb 2 2024, 1:56 PM
Unknown Object (File)
Dec 24 2023, 9:30 PM
Unknown Object (File)
Dec 14 2023, 2:34 PM
Unknown Object (File)
Oct 14 2023, 12:59 PM
View All 36 Files
Subscribers
emaste
imp

Details

Reviewers
wblock
bdrewery
Commits
rS314894: Fix a couple of typos and reword some sentences in bsd.README.
Summary

Fix a couple of typos and reword some sentences in bsd.README.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 26070.Mar 7 2017, 10:46 PM
jhb retitled this revision from to Fix a couple of typos and reword some sentences in bsd.README..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added reviewers: bdrewery, wblock.
Herald added subscribers: emaste, imp. · View Herald TranscriptMar 7 2017, 10:46 PM
bdrewery accepted this revision.Mar 7 2017, 10:49 PM
bdrewery edited edge metadata.

Oops, thanks.

This revision is now accepted and ready to land.Mar 7 2017, 10:49 PM
jhb added inline comments.Mar 7 2017, 10:54 PM
share/mk/bsd.README
53 ↗(On Diff #26070)

Should we remove the reference to the PMake document here? Alternatively, perhaps we should fix share/doc/psd/12.make to install the PSD docs from contrib/bmake instead of the the pmake document and then update the title? Hmm, the PSD docs in bmake is the same thing (but more correct than ours it seems. Ours has "makefilesystem" as a word where the NetBSD one has "makefile system" for example.) I guess we should leave this for now (though perhaps we should adopt the NetBSD PSD doc).

337 ↗(On Diff #26070)

The way the rest of this file is structured, it seems like there should be a separate section for bsd.progs.mk instead of sticking these variables in the list of bsd.prog.mk variables.

bdrewery added a comment.Mar 7 2017, 10:57 PM

Btw your changes may start conflicting with D9918 if you make more changes. I suggest checking that out anyhow.

share/mk/bsd.README
337 ↗(On Diff #26070)

That's fine so long as it only lists PROGS and PROGS_CXX and something like "The rest of the bsd.prog.mk section applies here as well".

jhb added inline comments.Mar 8 2017, 5:47 AM
share/mk/bsd.README
337 ↗(On Diff #26070)

If (big if) I do that it would be in a separate commit anyway.

I do think we should probably adopt the PSD make manual from bmake though (also would be a separate commit)

Closed by commit rS314894: Fix a couple of typos and reword some sentences in bsd.README. (authored by jhb). · Explain WhyMar 8 2017, 5:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
share/
mk/
10 lines

Diff 26075

View Options

head/share/mk/bsd.README

Loading...