Page MenuHomeFreeBSD

Fix ftp hang in libfetch after rS313974
AbandonedPublic

Authored by bapt on Mar 2 2017, 10:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 12:14 PM
Unknown Object (File)
Mar 12 2024, 7:15 AM
Unknown Object (File)
Oct 11 2023, 7:43 PM
Unknown Object (File)
Jul 10 2023, 10:51 PM
Unknown Object (File)
Jul 9 2023, 2:31 AM
Unknown Object (File)
Jun 30 2023, 2:49 PM
Unknown Object (File)
May 13 2023, 9:21 PM
Unknown Object (File)
May 8 2023, 1:29 PM
Subscribers

Details

Reviewers
dim
allanjude
des
Summary

In rS313974, a netrcfd field was added to struct url, to prepare for
capsicumization. The field should be initialized to -2, but this is
only done in fetchMakeURL(), not in fetchParseURL(). Since the ftp
part of libfetch only calls the latter, the netrcfd field is left at
its default value of zero, and fetching ftp:// URLs then hangs after the
server displays its banner, before authentication starts.

Fix this by initializing the netrcfd to -2 in fetchParseURL().

Diff Detail

Event Timeline

dim retitled this revision from to Fix ftp hang in libfetch after rS313974.
dim updated this object.
dim edited the test plan for this revision. (Show Details)
dim added reviewers: des, bapt, allanjude.
bapt abandoned this revision.
bapt edited reviewers, added: dim; removed: bapt.

Already committed