Page MenuHomeFreeBSD

Fix memory leaks in libdtrace
ClosedPublic

Authored by trix_juniper.net on Feb 21 2017, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 1:37 PM
Unknown Object (File)
Fri, Mar 15, 12:55 PM
Unknown Object (File)
Feb 11 2024, 3:04 PM
Unknown Object (File)
Dec 23 2023, 10:10 AM
Unknown Object (File)
Dec 21 2023, 5:41 AM
Unknown Object (File)
Nov 28 2023, 10:47 PM
Unknown Object (File)
Nov 13 2023, 11:58 AM
Unknown Object (File)
Nov 3 2023, 3:23 AM

Details

Summary

dt_open.c dt_provmod_open
When realloc fails, the original pointer is still valid, so it must be freed.

dt_open.c dt_vopen
When the malloc of dtp fails, the memory/structure previously assigned to provmod must be freed. dt_provmod_destroy handles the case when provmod == NULL so there is no need for special handling of jumping over the setup of provmod.

dt_strtab.c dt_strtab_insert
When the call to dt_strtab_copyin fails, it is necessary to free the locally allocated memory assigned to 'hp' before returning early.

Test Plan

Run clang's static analyzer scan-build before to reproduce the problem, run scan-build after to verify resolution of the problem.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trix_juniper.net retitled this revision from to Fix memory leaks in libdtrace.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.
markj edited edge metadata.
This revision is now accepted and ready to land.Feb 21 2017, 10:27 PM
This revision was automatically updated to reflect the committed changes.