Page MenuHomeFreeBSD

Introduce libxo to arp(8)
ClosedPublic

Authored by garga on Feb 13 2017, 12:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 7:04 PM
Unknown Object (File)
Tue, Mar 12, 7:08 AM
Unknown Object (File)
Tue, Mar 12, 7:08 AM
Unknown Object (File)
Tue, Mar 12, 7:03 AM
Unknown Object (File)
Tue, Mar 12, 7:03 AM
Unknown Object (File)
Tue, Mar 12, 7:03 AM
Unknown Object (File)
Tue, Mar 12, 7:03 AM
Unknown Object (File)
Tue, Mar 12, 7:03 AM
Subscribers

Details

Summary

Add libxo support to arp(8)

Sponsored by: Rubicon Communications (Netgate)
MFC after: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

garga retitled this revision from to Introduce libxo to arp(8).
garga updated this object.
garga edited the test plan for this revision. (Show Details)
garga added a reviewer: allanjude.

Do not print hostname and ip address when it's not on arp table

wblock added inline comments.
usr.sbin/arp/arp.8
39 ↗(On Diff #25087)

Does --libxo require options? Either way, this seems incomplete. Maybe

.Op Fl -libxo Ar options

or

.Op Fl -libxo Op Ar options

or something like that.

44 ↗(On Diff #25087)

As above.

This comment was removed by garga.
usr.sbin/arp/arp.8
39 ↗(On Diff #25087)

I've copied it from manpage of other binaries that already have libxo support. For instance netmap and df manpages are still like this in HEAD.

Should we add all possible libxo parameters on all binaries manpages?

usr.sbin/arp/arp.8
39 ↗(On Diff #25087)

No, it is not necessary to list all the options, but we need to tell the user that an option is either expected or can be added here.

If other man pages do not say an option is either mandatory or optional here, they are wrong.

garga edited edge metadata.

Let user know --libxo parameter requires options as pointed by wblock

wblock added a reviewer: wblock.

Man page looks okay to me. Please check with textproc/igor and mandoc -Tlint. Thanks!

This revision is now accepted and ready to land.Feb 17 2017, 7:39 PM
gnn edited edge metadata.
usr.sbin/arp/arp.c
179 ↗(On Diff #25323)

need a xo_set_version() call in here before the container

garga edited edge metadata.

Added xo_set_version() call

This revision now requires review to proceed.Mar 14 2017, 12:15 PM

Make some changes as suggested by Phil Shafer <phil@juniper.net>

  • Combine some xo_emit() calls
  • Move hard coded strings to main string on some xo_emit() calls
  • Change 'arp-table' to 'arp-cache'

Approved By: allanjude

usr.sbin/arp/arp.8
31 ↗(On Diff #27139)

update this to the current date before you commit

This revision is now accepted and ready to land.Apr 6 2017, 4:04 PM
This revision was automatically updated to reflect the committed changes.