Page MenuHomeFreeBSD
Differential D9558

Manage OLDDIRS for various targets.
ClosedPublic
Actions

Authored by sbruno on Feb 12 2017, 6:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 12:06 AM
Unknown Object (File)
Thu, Sep 25, 4:23 PM
Unknown Object (File)
Wed, Sep 24, 10:51 AM
Unknown Object (File)
Wed, Sep 24, 6:57 AM
Unknown Object (File)
Sep 11 2025, 3:39 PM
Unknown Object (File)
Aug 15 2025, 9:16 AM
Unknown Object (File)
Jul 25 2025, 7:45 AM
Unknown Object (File)
Jul 21 2025, 2:13 PM
View All 89 Files
Subscribers
imp

Details

Reviewers
ngie
bapt
Commits
rS313892: Update OLD_DIRS for various targets so that some of the branches of

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7450
Build 7612: arc lint + arc unit

Event Timeline

sbruno updated this revision to Diff 25060.Feb 12 2017, 6:43 PM
sbruno retitled this revision from to Manage OLDDIRS for various targets..
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added reviewers: ngie, bapt.
Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2017, 6:43 PM
ngie added inline comments.Feb 12 2017, 7:30 PM
tools/build/mk/OptionalObsoleteFiles.inc
2236–2237

Could you please delete this comment?

5595

Why did you delete this?

7939

Trailing slash?

sbruno updated this revision to Diff 25062.Feb 12 2017, 7:50 PM

Address multiple typos picked up in review.

sbruno marked 3 inline comments as done.Feb 12 2017, 7:52 PM

Address typos in review comments.

ngie edited edge metadata.Feb 13 2017, 7:49 AM

Please sort the entries alphabetically -- once that and the MK_EXAMPLES comments are done, this diff is good to go!

tools/build/mk/OptionalObsoleteFiles.inc
2236–2237

I totally missed that you need to uncomment this and the .endif at the end.

sbruno updated this revision to Diff 25161.Feb 14 2017, 2:45 PM
sbruno edited edge metadata.

Remove commented out MK_EXAMPLES and sort various targets by alpha.

ngie accepted this revision.Feb 14 2017, 5:53 PM
ngie edited edge metadata.

Quick note that it's OLD_DIRS, not OLDDIRS. The change is good to go -- thanks ;)!

This revision is now accepted and ready to land.Feb 14 2017, 5:53 PM
Closed by commit rS313892: Update OLD_DIRS for various targets so that some of the branches of (authored by sbruno). · Explain WhyFeb 17 2017, 8:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
tools/
build/
mk/
309 lines

Diff 25161

View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...