Manage OLDDIRS for various targets.
ClosedPublic
Actions

Authored by sbruno on Feb 12 2017, 6:43 PM.

Details

Reviewers

ngie
bapt

Commits

rS313892: Update OLD_DIRS for various targets so that some of the branches of

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7387
Build 7552: arc lint + arc unit

Event Timeline

sbruno updated this revision to Diff 25060.Feb 12 2017, 6:43 PM

sbruno retitled this revision from to Manage OLDDIRS for various targets..

sbruno updated this object.

sbruno edited the test plan for this revision. (Show Details)

sbruno added reviewers: ngie, bapt.

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2017, 6:43 PM

ngie added inline comments.Feb 12 2017, 7:30 PM

tools/build/mk/OptionalObsoleteFiles.inc
2238–2291	Could you please delete this comment?
5595	Why did you delete this?
7939	Trailing slash?

Address multiple typos picked up in review.

Address typos in review comments.

Please sort the entries alphabetically -- once that and the MK_EXAMPLES comments are done, this diff is good to go!

tools/build/mk/OptionalObsoleteFiles.inc
2237	I totally missed that you need to uncomment this and the `.endif` at the end.

Remove commented out MK_EXAMPLES and sort various targets by alpha.

Quick note that it's OLD_DIRS, not OLDDIRS. The change is good to go -- thanks ;)!

This revision is now accepted and ready to land.Feb 14 2017, 5:53 PM

Closed by commit rS313892: Update OLD_DIRS for various targets so that some of the branches of (authored by sbruno). · Explain WhyFeb 17 2017, 8:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tools/

build/

mk/

OptionalObsoleteFiles.inc

305 lines

Diff 25062

View Options

tools/build/mk/OptionalObsoleteFiles.inc

Manage OLDDIRS for various targets.ClosedPublicActions