Page MenuHomeFreeBSD
Differential D9510

usr.sbin/ndp/ndp.c: Fix style(9)
ClosedPublic
Actions

Authored by garga on Feb 9 2017, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 5:33 AM
Unknown Object (File)
Nov 21 2024, 10:37 AM
Unknown Object (File)
Nov 18 2024, 3:17 AM
Unknown Object (File)
Nov 17 2024, 2:04 PM
Unknown Object (File)
Nov 17 2024, 1:19 PM
Unknown Object (File)
Nov 17 2024, 12:14 PM
Unknown Object (File)
Nov 17 2024, 11:38 AM
Unknown Object (File)
Nov 17 2024, 9:24 AM
View All 80 Files
Subscribers
imp
pstef

Details

Reviewers
melifaro
hrs
allanjude
vangyzen
Commits
rS314041: MFC r313737:
rS313737: Fix style(9)
Summary

Fix style(9) on usr.sbin/ndp/ndp.c

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

garga updated this revision to Diff 24914.Feb 9 2017, 12:52 PM
garga retitled this revision from to usr.sbin/ndp/ndp.c: Fix style(9).
garga updated this object.
garga edited the test plan for this revision. (Show Details)
garga added a reviewer: allanjude.
Herald added a subscriber: imp. · View Herald TranscriptFeb 9 2017, 12:52 PM
allanjude added reviewers: melifaro, hrs.Feb 9 2017, 5:05 PM
pstef added a subscriber: pstef.Feb 9 2017, 6:04 PM
pstef added inline comments.
usr.sbin/ndp/ndp.c
941 ↗(On Diff #24914)

No tab.

garga updated this revision to Diff 24946.Feb 9 2017, 6:49 PM

Add missing TAB

usr.sbin/ndp/ndp.c
941 ↗(On Diff #24914)

Fixed

garga added a reviewer: vangyzen.Feb 14 2017, 9:10 AM
vangyzen added inline comments.Feb 14 2017, 3:15 PM
usr.sbin/ndp/ndp.c
148 ↗(On Diff #24946)

I appreciate your fervent interest in improving the code's style(9). However, nearly all of the new endif comments are actually against the style:

This comment should be used only for (subjectively) long regions, regions
greater than 20 lines, or where a series of nested #ifdef 's may be
confusing to the reader.

For short conditionally compiled
regions, a closing comment should not be used.

garga added inline comments.Feb 14 2017, 5:18 PM
usr.sbin/ndp/ndp.c
148 ↗(On Diff #24946)

I'm starting to add libxo support on some binaries then I decided to read the code before touch and then fix style on them. Of course I've missed the 20 lines rule and I'll update the patch soon.

Thanks

garga updated this revision to Diff 25166.Feb 14 2017, 5:24 PM

Remove wrong comments nearly endif for short blocks

vangyzen accepted this revision.Feb 14 2017, 5:29 PM
vangyzen edited edge metadata.
This revision is now accepted and ready to land.Feb 14 2017, 5:29 PM
allanjude accepted this revision.Feb 14 2017, 6:01 PM
allanjude edited edge metadata.

Approved By: allanjude

Closed by commit rS313737: Fix style(9) (authored by garga). · Explain WhyFeb 14 2017, 6:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
ndp/
80 lines

Diff 25171

View Options

head/usr.sbin/ndp/ndp.c

Loading...