ndp.c: Fix style(9)
ClosedPublic
Actions

Authored by garga on Feb 9 2017, 12:52 PM.

Details

Reviewers

Commits

rS314041: MFC r313737:
rS313737: Fix style(9)

Summary

Fix style(9) on usr.sbin/ndp/ndp.c

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

garga retitled this revision from to usr.sbin/ndp/ndp.c: Fix style(9).

garga updated this object.

garga edited the test plan for this revision. (Show Details)

garga added a reviewer: allanjude.

pstef added inline comments.

usr.sbin/ndp/ndp.c
941 ↗	(On Diff #24914)	No tab.

Add missing TAB

usr.sbin/ndp/ndp.c
941 ↗	(On Diff #24914)	Fixed

usr.sbin/ndp/ndp.c
148 ↗	(On Diff #24946)	I appreciate your fervent interest in improving the code's style(9). However, nearly all of the new endif comments are actually against the style: This comment should be used only for (subjectively) long regions, regions greater than 20 lines, or where a series of nested #ifdef 's may be confusing to the reader. For short conditionally compiled regions, a closing comment should not be used.

usr.sbin/ndp/ndp.c
148 ↗	(On Diff #24946)	I'm starting to add libxo support on some binaries then I decided to read the code before touch and then fix style on them. Of course I've missed the 20 lines rule and I'll update the patch soon. Thanks