Page MenuHomeFreeBSD

Improve sending of TCP window updates
ClosedPublic

Authored by tuexen on Feb 7 2017, 1:33 PM.

Details

Summary

An issue with the sending of window updates was reported in PR 211003. Window updates are only sent if the window can be increased by at least 2 * MSS. However, if the receive buffer size is small, this might be impossible.

Add back a criterion to send a TCP window update if the window can be increased by at least half of the receive buffer size. This condition was remove in r242252.
This patch simply brings it back.

Test Plan

Get the packetdrill test

working.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tuexen retitled this revision from to Improve sending of TCP window updates.Feb 7 2017, 1:33 PM
tuexen updated this object.
tuexen edited the test plan for this revision. (Show Details)
tuexen added reviewers: transport, hiren, rrs, gnn.
tuexen set the repository for this revision to rS FreeBSD src repository.
tuexen updated this revision to Diff 24830.
Herald added a subscriber: imp. · View Herald Transcript
gnn edited edge metadata.Feb 9 2017, 5:48 PM
gnn accepted this revision.
This revision is now accepted and ready to land.Feb 9 2017, 5:48 PM
This revision was automatically updated to reflect the committed changes.