Differential D9475

Improve sending of TCP window updates
ClosedPublic
Actions

Authored by tuexen on Feb 7 2017, 1:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 7, 5:32 AM

	Unknown Object (File)
	Sat, Apr 6, 6:05 PM

	Unknown Object (File)
	Mar 15 2024, 1:37 PM

	Unknown Object (File)
	Mar 15 2024, 12:55 PM

	Unknown Object (File)
	Feb 13 2024, 10:33 PM

	Unknown Object (File)
	Feb 13 2024, 7:47 PM

	Unknown Object (File)
	Dec 20 2023, 1:23 AM

	Unknown Object (File)
	Dec 7 2023, 4:39 PM

View All 45 Files

Subscribers

Details

Reviewers

hiren
rrs
gnn

Group Reviewers

Commits

rS319397: MFC r314155:
rS314155: TCP window updates are only sent if the window can be increased by at

Summary

An issue with the sending of window updates was reported in PR 211003. Window updates are only sent if the window can be increased by at least 2 * MSS. However, if the receive buffer size is small, this might be impossible.

Add back a criterion to send a TCP window update if the window can be increased by at least half of the receive buffer size. This condition was remove in r242252.
This patch simply brings it back.

Test Plan

Get the packetdrill test

missing_windown_update.pkt2 KBDownload

working.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen updated this revision to Diff 24830.Feb 7 2017, 1:33 PM

tuexen retitled this revision from to Improve sending of TCP window updates.

tuexen updated this object.

tuexen edited the test plan for this revision. (Show Details)

tuexen added reviewers: transport, hiren, rrs, gnn.

tuexen set the repository for this revision to rS FreeBSD src repository - subversion.

Herald edited edge metadata. · View Herald TranscriptFeb 7 2017, 1:33 PM

Herald added a subscriber: imp. · View Herald Transcript

gnn accepted this revision.Feb 9 2017, 5:48 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Feb 9 2017, 5:48 PM

Closed by commit rS314155: TCP window updates are only sent if the window can be increased by at (authored by tuexen). · Explain WhyFeb 23 2017, 6:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

2 lines

Diff 25633

head/sys/netinet/tcp_output.c

Loading...