Page MenuHomeFreeBSD

converters/bdes: Add bdes port as replacement of the base utility
ClosedPublic

Authored by brnrd on Feb 4 2017, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 31, 8:58 PM
Unknown Object (File)
Mar 11 2024, 4:16 PM
Unknown Object (File)
Feb 1 2024, 12:54 AM
Unknown Object (File)
Jan 10 2024, 1:46 AM
Unknown Object (File)
Jan 6 2024, 3:13 PM
Unknown Object (File)
Jan 1 2024, 9:28 AM
Unknown Object (File)
Dec 30 2023, 5:09 AM
Unknown Object (File)
Dec 17 2023, 3:28 AM
Subscribers

Details

Summary
converters/bdes: Add bdes port as replacement of the base utility

  - Add new port

Differential_Revision: D9435

See also Review D9429

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 7181
Build 7351: arc lint + arc unit

Event Timeline

brnrd retitled this revision from to converters/bdes: Add bdes port as replacement of the base utility.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: bapt, allanjude.
brnrd added a subscriber: rene.
brnrd edited the test plan for this revision. (Show Details)

This should go to the security category.

allanjude edited edge metadata.

Looks good to me.

I understand the desire to put it under converters/ or textproc/, but I think security/ is in fact the right place.

An application being in the security category does not constitute an endorsement by the project.

This revision is now accepted and ready to land.Feb 5 2017, 9:25 AM
brnrd edited edge metadata.

Move to security category

This revision now requires review to proceed.Feb 5 2017, 11:50 AM
brnrd edited edge metadata.
allanjude edited edge metadata.
This revision is now accepted and ready to land.Feb 5 2017, 1:33 PM
security/bdes/Makefile
18 ↗(On Diff #24761)

-O2 shouldn't be in CFLAGS, I think default flags would work just fine.

23 ↗(On Diff #24761)

Tab between && and ${CC} ? And probably drop CFLAGS here

brnrd marked 2 inline comments as done.Feb 5 2017, 8:11 PM
brnrd added inline comments.
security/bdes/Makefile
18 ↗(On Diff #24761)

CFLAGS were copied from Kirk McKusick's tarball
After removal it still builds fine

This revision was automatically updated to reflect the committed changes.
brnrd marked an inline comment as done.