Page MenuHomeFreeBSD
Differential D9435

converters/bdes: Add bdes port as replacement of the base utility
ClosedPublic
Actions

Authored by brnrd on Feb 4 2017, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 7:37 PM
Unknown Object (File)
Sat, Jan 18, 3:25 AM
Unknown Object (File)
Tue, Jan 14, 1:36 AM
Unknown Object (File)
Tue, Jan 14, 1:33 AM
Unknown Object (File)
Sun, Jan 12, 9:29 AM
Unknown Object (File)
Dec 7 2024, 12:00 AM
Unknown Object (File)
Dec 5 2024, 5:09 PM
Unknown Object (File)
Nov 30 2024, 5:50 PM
View All Files
Subscribers
mat
rene

Details

Reviewers
allanjude
bapt
Commits
rP433449: security/bdes: New port
Summary
converters/bdes: Add bdes port as replacement of the base utility

  - Add new port

Differential_Revision: D9435

See also Review D9429

Test Plan

10.3 i386
10.3 amd64
11.0 i386
11.0 amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brnrd updated this revision to Diff 24719.Feb 4 2017, 3:02 PM
brnrd retitled this revision from to converters/bdes: Add bdes port as replacement of the base utility.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: bapt, allanjude.
brnrd added a subscriber: rene.
Herald added a subscriber: mat. · View Herald TranscriptFeb 4 2017, 3:02 PM
brnrd mentioned this in D9424: remove bdes(1).Feb 4 2017, 3:04 PM
brnrd updated this object.Feb 4 2017, 3:07 PM
brnrd edited the test plan for this revision. (Show Details)
brnrd updated this revision to Diff 24720.Feb 4 2017, 3:11 PM

Fix LICENSE

mat added a comment.Feb 4 2017, 5:10 PM

This should go to the security category.

allanjude accepted this revision.Feb 5 2017, 9:25 AM
allanjude edited edge metadata.

Looks good to me.

I understand the desire to put it under converters/ or textproc/, but I think security/ is in fact the right place.

An application being in the security category does not constitute an endorsement by the project.

This revision is now accepted and ready to land.Feb 5 2017, 9:25 AM
brnrd updated this revision to Diff 24761.Feb 5 2017, 11:50 AM
brnrd edited edge metadata.

Move to security category

This revision now requires review to proceed.Feb 5 2017, 11:50 AM
brnrd updated this object.Feb 5 2017, 11:51 AM
brnrd edited edge metadata.
allanjude accepted this revision.Feb 5 2017, 1:33 PM
allanjude edited edge metadata.
This revision is now accepted and ready to land.Feb 5 2017, 1:33 PM
rene added inline comments.Feb 5 2017, 1:44 PM
security/bdes/Makefile
18 ↗(On Diff #24761)

-O2 shouldn't be in CFLAGS, I think default flags would work just fine.

23 ↗(On Diff #24761)

Tab between && and ${CC} ? And probably drop CFLAGS here

brnrd marked 2 inline comments as done.Feb 5 2017, 8:11 PM
brnrd added inline comments.
security/bdes/Makefile
18 ↗(On Diff #24761)

CFLAGS were copied from Kirk McKusick's tarball
After removal it still builds fine

Closed by commit rP433449: security/bdes: New port (authored by brnrd). · Explain WhyFeb 5 2017, 8:13 PM
This revision was automatically updated to reflect the committed changes.
brnrd marked an inline comment as done.
brnrd mentioned this in rP433449: security/bdes: New port.

Revision Contents
Changeset List

PathSize
head/
security/
1 line
bdes/
29 lines
3 lines
9 lines
4 lines

Diff 24776

View Options

head/security/Makefile

Loading...
View Options

head/security/bdes/Makefile

Loading...
View Options

head/security/bdes/distinfo

Loading...
View Options

head/security/bdes/pkg-descr

Loading...
View Options

head/security/bdes/pkg-message

Loading...