Page MenuHomeFreeBSD

devel/cargo: Fix `cargo-nightly*` checksum & size in distinfo.i386
ClosedPublic

Authored by dumbbell on Jan 22 2017, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 13 2024, 8:30 PM
Unknown Object (File)
Mar 13 2024, 8:29 PM
Unknown Object (File)
Mar 13 2024, 8:29 PM
Unknown Object (File)
Mar 13 2024, 8:29 PM
Unknown Object (File)
Mar 13 2024, 8:29 PM
Unknown Object (File)
Mar 13 2024, 8:29 PM
Unknown Object (File)
Mar 13 2024, 8:12 PM
Unknown Object (File)
Jan 11 2024, 7:57 AM
Subscribers

Details

Summary

devel/cargo and lang/rust-nightly both download an unversioned file and unfortunately, the wrong file was used to fill the checksum/size in devel/cargo.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell retitled this revision from to devel/cargo: Fix `cargo-nightly*` checksum & size in distinfo.i386.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: antoine, bapt, jbeich.
jbeich edited edge metadata.

Looks same as what I have locally. Thanks.

This revision is now accepted and ready to land.Jan 22 2017, 7:27 PM

You can use DIST_SUBDIR= 2016-11-02 or something similar to put an unversioned file in a versioned directory

I'm asking the same question I asked on svn-ports-all@:

When several ports are fetching different files having the same name (binary bootstraps in this case), what should those ports do? Is using a subdirectory in ${DISTDIR} the appropriate solution? Because they are also sharing files (like source archives).

You can use DIST_SUBDIR= 2016-11-02 or something similar to put an unversioned file in a versioned directory

Can it be per-DISTFILE?

Maybe create separate port(s) for bootstrap and install them somewhere outside of PATH. However, the real fix would be per-distfile subdirectory support via bsd.port.mk.

Thanks to both of you.

I will update the patch to put files in ${DIST_SUBDIR} for now to fix the port.

dumbbell edited edge metadata.

Set ${DIST_SUBDIR} to ${PORTNAME}

This revision now requires review to proceed.Jan 22 2017, 7:39 PM
jbeich edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2017, 7:46 PM
dumbbell edited edge metadata.

Put Cargo bootstrap in ${DISTDIR}/2016-11-02

This revision now requires review to proceed.Jan 23 2017, 9:12 AM

Please wait for another revision for this patch before reviewing, I want to include a fix to the following bug report:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216385

Poudriere is running.

dumbbell edited edge metadata.

Use ${OPENSSLBASE} from USES=ssl

Ok, this patch is ready for another review.

antoine edited edge metadata.

Approved with a PORTREVISION bump : on FreeBSD 10 with BOOTSTRAP option ON, it switches from openssl from ports to whatever ssl the user wants.

This revision is now accepted and ready to land.Jan 23 2017, 8:31 PM
This revision was automatically updated to reflect the committed changes.