Page MenuHomeFreeBSD

Fix py-pykde4 against newest clang
ClosedPublic

Authored by adridg on Jan 19 2017, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 6 2017, 1:15 PM
Unknown Object (File)
Feb 24 2017, 7:30 AM
Unknown Object (File)
Feb 17 2017, 12:19 AM
Unknown Object (File)
Feb 7 2017, 4:01 PM
Unknown Object (File)
Feb 4 2017, 3:36 AM
Subscribers

Details

Summary

PyList_SET_ITEM() is supposed to be void, but as a macro it's an
expression and has a pointer value. Clang 4.0 trips on the bogus
pointer comparison; given the comparison, it should be PyList_SetItem()
which returns -1 on failure.

Test Plan

py-kde4 builds with these patches on -CURRENT with the clang4 branch.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adridg retitled this revision from to Fix py-pykde4 against newest clang.
adridg updated this object.
adridg edited the test plan for this revision. (Show Details)
adridg added reviewers: tcberner, jbeich, rakuco.
adridg added a subscriber: kde.

Before Tobias reminds me that there should be an explanation of
why the patches are necessary ..

tcberner edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jan 20 2017, 7:49 AM
This revision was automatically updated to reflect the committed changes.