Page MenuHomeFreeBSD
Differential D9042

Fix a regression in r310638.
ClosedPublic
Actions

Authored by kib on Jan 4 2017, 10:39 AM.
Tags
None
Referenced Files
F171006354: D9042.id23597.diff
Tue, Sep 8, 3:54 AM
Unknown Object (File)
Thu, Aug 27, 11:04 AM
Unknown Object (File)
Sun, Aug 23, 4:43 PM
Unknown Object (File)
Wed, Aug 19, 8:53 PM
Unknown Object (File)
Thu, Aug 13, 9:08 PM
Unknown Object (File)
Thu, Aug 13, 8:08 PM
Unknown Object (File)
Thu, Aug 13, 12:09 PM
Unknown Object (File)
Wed, Aug 12, 11:59 AM
View All Files
Subscribers
imp
pho

Details

Reviewers
jhb
trasz
Commits
rS311286: The callers of kern_getfsstat(UIO_SYSSPACE) expect that *buf always
Summary

The callers of kern_getfsstat(UIO_SYSSPACE) expect that *buf always return memory which must be freed, regardless of the error. Assign NULL to *buf in case we are not going to allocate any memory due to invalid mode.

Test Plan

Reported and tested by: pho

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib updated this revision to Diff 23597.Jan 4 2017, 10:39 AM
kib retitled this revision from to Fix a regression in r310638..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added reviewers: jhb, trasz.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
kib added a subscriber: pho.
Herald added a subscriber: imp. · View Herald TranscriptJan 4 2017, 10:39 AM
jhb accepted this revision.Jan 4 2017, 3:46 PM
jhb edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2017, 3:46 PM
Closed by commit rS311286: The callers of kern_getfsstat(UIO_SYSSPACE) expect that *buf always (authored by kib). · Explain WhyJan 4 2017, 4:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
2 lines

Diff 23602

View Options

head/sys/kern/vfs_syscalls.c

Loading...