Page MenuHomeFreeBSD

Add a section about LXQt components to porters handbook

Authored by sevan on Jan 4 2017, 5:17 AM.
Referenced Files
Unknown Object (File)
Mon, Mar 6, 1:37 PM
Unknown Object (File)
Thu, Mar 2, 5:01 AM
Unknown Object (File)
Feb 14 2023, 12:51 AM
Unknown Object (File)
Apr 27 2017, 9:20 AM
Unknown Object (File)
Apr 22 2017, 4:03 PM
Unknown Object (File)
Apr 8 2017, 12:59 AM
Unknown Object (File)
Apr 6 2017, 11:44 PM
Unknown Object (File)
Apr 6 2017, 5:52 PM



Bug 215650

Diff Detail

rD FreeBSD doc repository - subversion
Lint Not Applicable
Tests Not Applicable

Event Timeline

sevan retitled this revision from to Add a section about LXQt components to porters handbook.
sevan updated this object.
sevan edited the test plan for this revision. (Show Details)
sevan added a reviewer: bcr.
sevan set the repository for this revision to rD FreeBSD doc repository - subversion.

The components list seems to match up with Mk/Uses/ and the content looks fine to me.

2 textual suggestions...

2906 ↗(On Diff #23594)

Maybe s/brings/adds a/ ?

2908 ↗(On Diff #23594)

Maybe s/through/from the/ ?

bjk added inline comments.
2863 ↗(On Diff #23594)

It's probably best to explicitly say "commonly used components" to be clear about what these values are.

2880 ↗(On Diff #23594)

I don't understand what this entry is -- is it helpers *for* additional CMake modules, or additional CMake modules that are helpful, or ...?

sevan edited edge metadata.

updated diff addressing the items listed.

bjk added a reviewer: bjk.
wblock added inline comments.
2861 ↗(On Diff #24036)

Suspect this should be "...and set <varname>USE_LXQT</varname>"

2863 ↗(On Diff #24036)

Avoid the aside: "...below and also documented..." (and remember to remove the closing paren) (yes that's an aside, and this one too)

sevan edited edge metadata.

updated diff with context posted.

2860 ↗(On Diff #24399)

Try to avoid if/then sentences. Occasional use is okay, but still, try to avoid. Often just rearranging them gets rid of the if/then and pause:

Applications depending on LXQt should set
2863 ↗(On Diff #24399)

Below, it just says "Available LXQt Components". Isn't that all of them? If it is, this can just say "...a list of needed components from the table below."

sevan removed a reviewer: mat.
sevan marked 2 inline comments as done.Mar 3 2017, 6:56 PM

Addressed the remaining two points.

wblock added a reviewer: wblock.

Approved for great justice!

This revision was automatically updated to reflect the committed changes.