Page MenuHomeFreeBSD

sfxge(4): use correct port number in sensor decoding
ClosedPublic

Authored by arybchik on Dec 28 2016, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 2, 9:54 AM
Unknown Object (File)
Sun, Sep 28, 3:23 PM
Unknown Object (File)
Wed, Sep 24, 12:30 AM
Unknown Object (File)
Mon, Sep 22, 7:29 PM
Unknown Object (File)
Sep 4 2025, 1:25 AM
Unknown Object (File)
Aug 2 2025, 10:48 PM
Unknown Object (File)
Jun 30 2025, 9:02 PM
Unknown Object (File)
Jun 29 2025, 5:45 AM
Subscribers

Details

Summary

The port mask used for per-port sensors in mcdi_sensor_map
assumes zero-based port numbering. The port mask used in
the code is based on the one-based MCDI port number.

Fix this to lookup the correct per-port sensors, and to
allow reporting of sensor events from higher port numbers.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 kernels tinderbox build tested

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik retitled this revision from to sfxge(4): use correct port number in sensor decoding.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added reviewers: gnn, philip, np, bz.
gnn edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 4:44 PM
This revision was automatically updated to reflect the committed changes.