Page MenuHomeFreeBSD

sfxge(4): fix efx_ev_qpoll for non-Siena builds
ClosedPublic

Authored by arybchik on Dec 28 2016, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 12:24 AM
Unknown Object (File)
Aug 16 2025, 1:34 AM
Unknown Object (File)
Aug 7 2025, 2:43 AM
Unknown Object (File)
Aug 1 2025, 11:36 PM
Unknown Object (File)
Jul 22 2025, 4:53 AM
Unknown Object (File)
Jul 6 2025, 11:39 AM
Unknown Object (File)
Jul 5 2025, 10:04 PM
Unknown Object (File)
Jul 5 2025, 3:40 AM
Subscribers

Details

Summary

Both Siena and EF10 use the siena_ev_qpoll() implementation, but this
function is not defined in builds without EFSYS_OPT_SIENA.

Remove siena_ev_qpoll and inline it into efx_ev_qpoll to allow it
to be used in non-Siena builds.

Also remove outdated FIXME comment, as EF10 event batching/merging has
been implemented long ago without needing to modify this code.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 kernels tinderbox build tested.
Driver loaded/unloaded on Siena and EF10.
Traffic works fine.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik retitled this revision from to sfxge(4): fix efx_ev_qpoll for non-Siena builds.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added reviewers: gnn, philip, np, bz.
gnn edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 4:40 PM
This revision was automatically updated to reflect the committed changes.