Page MenuHomeFreeBSD

iasl: Remove date and time from -vd option, for reproducible build
AbandonedPublic

Authored by emaste on Dec 19 2016, 5:50 PM.

Details

Reviewers
jkim
Summary

iasl's use of __DATE__ and __TIME__ is one of two issues remaining preventing a reproducible build of FreeBSD world + kernel.

The build date and time is not particularly relevant, so just remove it (instead of pinning it to an arbitrary value, via e.g. SOURCE_DATE_EPOCH).

PR: 215421

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste updated this revision to Diff 23098.Dec 19 2016, 5:50 PM
emaste retitled this revision from to iasl: Remove nonreproducible -vd (build date & time) option.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: jkim.
emaste added subscribers: bapt, jhb, gjb.
emaste added inline comments.Dec 20 2016, 8:15 PM
sys/contrib/dev/acpica/compiler/asloptions.c
728–729

I argue that this is not useful information and we're better off just omitting the option, but if prefered we could either change it to "%s Build date/time: unknown\n", ASL_COMPILER_NAME, or hard-code an arbitrary date/time.

emaste updated this revision to Diff 23224.Dec 23 2016, 8:52 PM
emaste retitled this revision from iasl: Remove nonreproducible -vd (build date & time) option to iasl: Remove date and time from -vd option, for reproducible build.

Leave -vd in place, just remove the nonreproducible date and time

emaste abandoned this revision.Jan 6 2017, 6:11 PM

@jkim committed rS311529