Page MenuHomeFreeBSD
Differential D8816

don't install and then remove cc.4.gz
ClosedPublic
Actions

Authored by lifanov on Dec 16 2016, 3:07 PM.
Tags
None
Referenced Files
F106650190: D8816.diff
Fri, Jan 3, 9:17 AM
Unknown Object (File)
Nov 15 2024, 2:10 PM
Unknown Object (File)
Oct 24 2024, 9:49 PM
Unknown Object (File)
Oct 22 2024, 1:48 PM
Unknown Object (File)
Oct 22 2024, 1:48 PM
Unknown Object (File)
Oct 22 2024, 1:28 PM
Unknown Object (File)
Sep 30 2024, 12:55 AM
Unknown Object (File)
Sep 23 2024, 6:56 PM
View All 56 Files
Subscribers
imp
koobs

Details

Reviewers
jhb
np
matthew
lstewart
Commits
rS310160: retain cc.4.gz man page for Chelsio T6 NICs
Summary

The cc.4.gz man page was removed as part of old conjestion control man pages but was re-added to document the T6 Chelsio driver. Right now "make install; make delete-old" is non-convergent and Trond Endrestøl reported this on freebsd-current...

Test Plan

man 4 cc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6271
Build 6514: arc lint + arc unit

Event Timeline

lifanov updated this revision to Diff 22996.Dec 16 2016, 3:07 PM
lifanov retitled this revision from to don't install and then remove cc.4.gz.
lifanov updated this object.
lifanov edited the test plan for this revision. (Show Details)
lifanov added reviewers: matthew, np, lstewart.
lifanov added a subscriber: koobs.
Herald added a subscriber: imp. · View Herald TranscriptDec 16 2016, 3:07 PM
lifanov updated this object.Dec 16 2016, 3:41 PM
np accepted this revision.Dec 16 2016, 4:22 PM
np edited edge metadata.

Thank you for the patch. Looks good to me but do you want to add a comment saying cc.4 used to be congestion control, was retired, and then reclaimed by cxgbe? 2011 was a long time back so I think it's ok to make this change regardless.

This revision is now accepted and ready to land.Dec 16 2016, 4:22 PM
np added a reviewer: jhb.Dec 16 2016, 4:22 PM
lifanov added a comment.Dec 16 2016, 4:27 PM

Hi np! I don't see an example of comments like this in ObsoleteFiles.inc, so it may be breaking with tradition.
Can you approve this please? I don't have a src bit. I'll also wait for my mentor to approve.

matthew accepted this revision.Dec 16 2016, 4:35 PM
matthew edited edge metadata.

LGTM, as mentor

np added a comment.Dec 16 2016, 5:40 PM
In D8816#182545, @lifanov wrote:

Hi np! I don't see an example of comments like this in ObsoleteFiles.inc, so it may be breaking with tradition.
Can you approve this please? I don't have a src bit. I'll also wait for my mentor to approve.

I've accepted this revision already.

Closed by commit rS310160: retain cc.4.gz man page for Chelsio T6 NICs (authored by lifanov). · Explain WhyDec 16 2016, 5:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line

Diff 22996

View Options

ObsoleteFiles.inc

Loading...