Page MenuHomeFreeBSD

Don't panic in vm_radix_remove(); instead return a value
ClosedPublic

Authored by alc on Dec 4 2016, 6:46 AM.
Tags
None
Referenced Files
F139636705: D8708.id22750.diff
Sun, Dec 14, 11:00 AM
Unknown Object (File)
Sat, Dec 6, 7:46 AM
Unknown Object (File)
Mon, Dec 1, 10:03 AM
Unknown Object (File)
Mon, Nov 24, 4:23 PM
Unknown Object (File)
Sat, Nov 22, 6:00 PM
Unknown Object (File)
Fri, Nov 21, 1:43 AM
Unknown Object (File)
Fri, Nov 21, 1:41 AM
Unknown Object (File)
Fri, Nov 21, 1:40 AM
Subscribers

Details

Summary

Change vm_radix_remove() to return a value, specifically, a vm_page_t or NULL, rather than panic()ing when the specified index isn't found in the trie. This change simplifies the pmap's use of tries for page table pages, specifically, we no longer have to do a lookup before every remove.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

alc retitled this revision from to Don't panic in vm_radix_remove(); instead return a value.
alc updated this object.
alc edited the test plan for this revision. (Show Details)
alc added reviewers: kib, markj, andrew.
kib edited edge metadata.
This revision is now accepted and ready to land.Dec 4 2016, 2:01 PM
markj edited edge metadata.
This revision was automatically updated to reflect the committed changes.