hyperv/storvsc: Don't use timedwait; mainly to unbreak EARLY_AP_STARTUP
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Nov 28 2016, 6:09 AM.

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
jhb
delphij
royger

Commits

rS309320: hyperv/storvsc: Don't use timedwait.

Summary

The timeout is unnecessary, nuking it unbreaks EARLY_AP_STARTUP.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 22555.Nov 28 2016, 6:09 AM

sepherosa_gmail.com retitled this revision from to hyperv/storvsc: Don't use timedwait; mainly to unbreak EARLY_AP_STARTUP.

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, jhb.

If you don't need the timeout, that is fine to remove of course. If you need the timeout for other reasons, see if rS309148 fixes the panics for you.

In D8656#179616, @jhb wrote:

If you don't need the timeout, that is fine to remove of course. If you need the timeout for other reasons, see if rS309148 fixes the panics for you.

I don't think it should use timed out wait here. I will stripe the EARLY_AP_STARTUP part from the commit log. Thanks.

Closed by commit rS309320: hyperv/storvsc: Don't use timedwait. (authored by sephe). · Explain WhyNov 30 2016, 8:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hyperv/

storvsc/

hv_storvsc_drv_freebsd.c

38 lines

Diff 22614

View Options

head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

hyperv/storvsc: Don't use timedwait; mainly to unbreak EARLY_AP_STARTUPClosedPublicActions