Add a keyword to handle services

[adamw]

I think this is a phenomenal idea. The only downside that I can see is when two ports want services on the same ports (such as bacula-server and bareos-server), but really given that they're mostly nomenclature this shouldn't cause much problem.

[adamw]

Keywords/service.ucl

24

This should probably be "Adding entry" to match the "Removing entry" below.

[bapt]

Better wording

[bcr]

One more wording suggestion (comment only).

Keywords/service.ucl

8

s/remove/removing/

[bapt]

Better wording

[bdrewery]

A call to services_mkdb((8) is missing for install and deinstall. Otherwise I like it.

[bapt]

actually service_mkdb is not used on freebsd (aka not activated by default)

[bdrewery]

In D8504#176842, @bapt wrote:

actually service_mkdb is not used on freebsd (aka not activated by default)

Sure it is:

etc/Makefile: services_mkdb ${CAP_MKDB_ENDIAN} -q -o ${DESTDIR}/var/db/services.db \
usr.sbin/etcupdate/etcupdate.sh: log "services_mkdb -q -o $DESTDIR/var/db/services.db" \
usr.sbin/mergemaster/mergemaster.sh: echo " '/usr/sbin/services_mkdb -q -o ${DESTDIR}/var/db/services.db ${DESTDIR}/etc/services'"

[bdrewery]

Sure, "db" is not used by default in nsswitch.conf, so /var/db/services.db is not used, but generating the db is done in base tools that modify /etc/services just in case. So I think this should as well.

[mat]

Keywords/service.ucl

19–22

This should be:

if awk ...

33

same here.

[bapt]

Keywords/service.ucl

19–22

I decided not to for readibility because the awk line is already long enough

[mat]

Mmmm, isn't there something you need to say if you want the multiple args to be split ? some arguments: true, or something ?