Page MenuHomeFreeBSD
Differential D8497

Remove most of the now unused code for implementing PG_CACHED pages.
ClosedPublic
Actions

Authored by alc on Nov 11 2016, 5:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 6:06 AM
Unknown Object (File)
Wed, Jan 15, 2:33 AM
Unknown Object (File)
Tue, Jan 14, 12:09 AM
Unknown Object (File)
Fri, Jan 10, 1:16 AM
Unknown Object (File)
Wed, Jan 8, 11:07 AM
Unknown Object (File)
Dec 27 2024, 11:48 AM
Unknown Object (File)
Dec 26 2024, 2:13 PM
Unknown Object (File)
Dec 21 2024, 1:03 AM
View All Files
Subscribers
delphij
pho

Details

Reviewers
kib
markj
Commits
rS308691: Remove most of the code for implementing PG_CACHED pages. (This change does
Summary

This revision removes most of the code for implementing PG_CACHED pages. It does not remove user-space visible fields from vm_cnt or all of the references to cached pages from comments. Those changes will come later.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc updated this revision to Diff 22147.Nov 11 2016, 5:13 PM
alc retitled this revision from to Remove most of the now unused code for implementing PG_CACHED pages..
alc updated this object.
alc edited the test plan for this revision. (Show Details)
alc added reviewers: kib, markj.
alc added a subscriber: pho.
Herald added a subscriber: delphij. · View Herald TranscriptNov 11 2016, 5:13 PM
kib accepted this revision.Nov 11 2016, 6:28 PM
kib edited edge metadata.
kib added inline comments.
vm/vm_page.c
1786 ↗(On Diff #22147)

The description 'initialize' is somewhat weird for the remnants of this function. It only manages bookkeeping for the phys allocator, effectively.

This revision is now accepted and ready to land.Nov 11 2016, 6:28 PM
markj edited edge metadata.EditedNov 11 2016, 6:34 PM

There are some callers of vm_page_alloc() that can be simplified a bit. For instance, shm_dotruncate() no longer needs to check the valid bits of the page returned by vm_page_alloc(). I believe the valid bit check in vm_page_grab() can be removed as well.

alc added inline comments.Nov 12 2016, 8:46 AM
vm/vm_page.c
1786 ↗(On Diff #22147)

I'd like to propose some refactoring: Move the vm_phys_freecnt_adj() back to the callers, leaving only the KASSERT()s in this function. (This is actually an optimization for vm_page_alloc_contig().) Rename the function to vm_page_alloc_check(), and move the calls to a point after the free queue lock is released.

alc updated this revision to Diff 22169.Nov 12 2016, 8:54 AM
alc edited edge metadata.

Refactor (and rename) vm_page_alloc_init().

This revision now requires review to proceed.Nov 12 2016, 8:54 AM
kib accepted this revision.Nov 12 2016, 1:09 PM
kib edited edge metadata.

I alike the update, and agree with it.

This revision is now accepted and ready to land.Nov 12 2016, 1:09 PM
alc added a comment.Nov 12 2016, 4:49 PM
In D8497#176612, @markj wrote:

There are some callers of vm_page_alloc() that can be simplified a bit. For instance, shm_dotruncate() no longer needs to check the valid bits of the page returned by vm_page_alloc(). I believe the valid bit check in vm_page_grab() can be removed as well.

Yes, and also vm_fault(). Today, I'm going to review all of the callers to vm_page_alloc() and update them where appropriate. I expect that to be the final change to this patch.

alc updated this revision to Diff 22174.Nov 12 2016, 5:48 PM
alc edited edge metadata.

Simplify callers to vm_page_alloc().

This revision now requires review to proceed.Nov 12 2016, 5:48 PM
markj accepted this revision.Nov 12 2016, 5:49 PM
markj edited edge metadata.
This revision is now accepted and ready to land.Nov 12 2016, 5:49 PM
alc added a comment.Nov 12 2016, 5:56 PM

Peter, could you please run this patch through your regular battery of tests?

kib added inline comments.Nov 12 2016, 5:57 PM
fs/tmpfs/tmpfs_subr.c
1375 ↗(On Diff #22174)

Having vm_pager_get_pages() in the else block is not very useful: the previous then block ends in goto. Moving it out of else block reduces indent.

kern/uipc_shm.c
458 ↗(On Diff #22174)

Same there.

pho added a comment.Nov 12 2016, 6:01 PM
In D8497#176808, @alc wrote:

Peter, could you please run this patch through your regular battery of tests?

Sure.

alc updated this revision to Diff 22175.Nov 12 2016, 6:11 PM
alc edited edge metadata.

Style only changes to tmpfs_subr.c and uipc_shm.c.

This revision now requires review to proceed.Nov 12 2016, 6:11 PM
alc marked 2 inline comments as done.Nov 12 2016, 6:12 PM
kib accepted this revision.Nov 12 2016, 6:25 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Nov 12 2016, 6:25 PM
pho added a comment.Nov 13 2016, 6:56 PM
In D8497#176808, @alc wrote:

Peter, could you please run this patch through your regular battery of tests?

I ran all of the tests I have and found no problems.

Closed by commit rS308691: Remove most of the code for implementing PG_CACHED pages. (This change does (authored by alc). · Explain WhyNov 15 2016, 6:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
cddl/
compat/
opensolaris/
sys/
3 lines
contrib/
opensolaris/
uts/
common/
fs/
zfs/
4 lines
fs/
tmpfs/
9 lines
kern/
2 lines
9 lines
vm/
5 lines
3 lines
3 lines
8 lines
39 lines
6 lines
364 lines
1 line
39 lines
10 lines

Diff 22225

View Options

head/sys/cddl/compat/opensolaris/sys/vnode.h

Loading...
View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

Loading...
View Options

head/sys/fs/tmpfs/tmpfs_subr.c

Loading...
View Options

head/sys/kern/kern_exec.c

Loading...
View Options

head/sys/kern/uipc_shm.c

Loading...
View Options

head/sys/vm/swap_pager.c

Loading...
View Options

head/sys/vm/vm_fault.c

Loading...
View Options

head/sys/vm/vm_mmap.c

Loading...
View Options

head/sys/vm/vm_object.h

Loading...
View Options

head/sys/vm/vm_object.c

Loading...
View Options

head/sys/vm/vm_page.h

Loading...
View Options

head/sys/vm/vm_page.c

Loading...
View Options

head/sys/vm/vm_reserv.h

Loading...
View Options

head/sys/vm/vm_reserv.c

Loading...
View Options

head/sys/vm/vnode_pager.c

Loading...