net/wpa_gui: update to version 2.6
PR: 213827
Depends on: D8451
Differential D8401
net/wpa_gui: update to version 2.6 jrm on Oct 31 2016, 5:11 PM. Authored by Tags None Referenced Files
Subscribers
Details
net/wpa_gui: update to version 2.6 PR: 213827 portlint -C: OK
Diff Detail
Event TimelineComment Actions LGTM, but I'd suggest to add LICENSE_FILE (see wpa_supplicant port), merge first three PLIST_FILES entries into single "@(,,4555) sbin/wpa_gui" entry, silence MKDIRS and unsilence GZIPs. Comment Actions I must be missunderstanding what you you mean by, "merge first three PLIST_FILES entries into single '@(,,4555) sbin/wpa_gui'". Certainly you don't want the other files setuid and executable. I left the mkdirs unsilenced in the do-install target, because I recall recommendations to not silence in do-install. If that's not the case, perhaps section 5.15.3 of the handbook should be updated. Comment Actions @(,,4555) sbin/wpa_gui ... only makes sbin/wpa_gui setuid and executable
I though we've had a rule (not sure of it's documented) to silence MKDIRS and COPYTREE macros. The former are unimportant and the latter are unreadable in the logs (probably need an "echo" added to them) Comment Actions
Comment Actions Update files/pkg-message.in I believe some of the information is inaccurate and some is redundant (contained |