net/wpa_gui: update to version 2.6

[jrm]

Summary

net/wpa_gui: update to version 2.6

PR: 213827
Depends on: D8451

Test Plan

portlint -C: OK
testport: OK (poudriere: 9.3-RELEASE-p48, i386, default options)
testport: OK (poudriere: 9.3-RELEASE-p48, amd64, default options)
testport: OK (poudriere: 10.3-RELEASE-p10, i386, default options)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, i386, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64, default options)

[swills]

Approved

[jrm]

• Redo the diff after other commits
• Readd the necessary patches

[AMDmi3]

LGTM, but I'd suggest to add LICENSE_FILE (see wpa_supplicant port), merge first three PLIST_FILES entries into single "@(,,4555) sbin/wpa_gui" entry, silence MKDIRS and unsilence GZIPs.

[jrm]

• Add LICENSE_FILE
• Unsilence gzipping in post-install target

[jrm]

I must be missunderstanding what you you mean by, "merge first three PLIST_FILES entries into single '@(,,4555) sbin/wpa_gui'". Certainly you don't want the other files setuid and executable.

I left the mkdirs unsilenced in the do-install target, because I recall recommendations to not silence in do-install. If that's not the case, perhaps section 5.15.3 of the handbook should be updated.

[AMDmi3]

In D8401#176675, @jrm wrote:

I must be missunderstanding what you you mean by, "merge first three PLIST_FILES entries into single '@(,,4555) sbin/wpa_gui'". Certainly you don't want the other files setuid and executable.

@(,,4555) sbin/wpa_gui
...

only makes sbin/wpa_gui setuid and executable

I left the mkdirs unsilenced in the do-install target, because I recall recommendations to not silence in do-install. If that's not the case, perhaps section 5.15.3 of the handbook should be updated.

I though we've had a rule (not sure of it's documented) to silence MKDIRS and COPYTREE macros. The former are unimportant and the latter are unreadable in the logs (probably need an "echo" added to them)

[jrm]

• Use an empty keyword to set the wpa_gui binary setuid.
• Silence MKDIR in do-install target

[jrm]

Update files/pkg-message.in

I believe some of the information is inaccurate and some is redundant (contained
in the message when security/wpa_supplicant is installed).

[jrm]

Correction to files/pkg-message.in

[swills]

Approved