Differential D8391

hyperv/utility: share status return values
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Oct 31 2016, 5:33 AM.

Tags

None

Referenced Files

	F133182739: D8391.id21869.diff
	Thu, Oct 23, 6:20 PM

	Unknown Object (File)
	Sun, Oct 19, 11:40 AM

	Unknown Object (File)
	Mon, Oct 13, 5:37 AM

	Unknown Object (File)
	Mon, Oct 13, 5:37 AM

	Unknown Object (File)
	Mon, Oct 13, 5:37 AM

	Unknown Object (File)
	Mon, Oct 13, 5:37 AM

	Unknown Object (File)
	Sun, Oct 12, 5:41 PM

	Unknown Object (File)
	Sun, Oct 12, 3:51 AM

Subscribers

None

Details

Reviewers

howard0su_gmail.com
decui_microsoft.com
hrs
delphij
sepherosa_gmail.com
royger

Commits

rS308201: hyperv/kvp: Don't mix message status codes and function return values.

Summary

This patch did the following improvements:
(1) Never use the status flag as return values for both hv_kvp_daemon and hv_kvp.c.
(2) Move the status code from kvp specific file to a shared file, which can be used by other utility modules, like VSS.
(3) Fix the issue of missing quote.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5757
Build 6061: arc lint + arc unit

Event Timeline

honzhan_microsoft.com updated this revision to Diff 21822.Oct 31 2016, 5:33 AM

honzhan_microsoft.com retitled this revision from to hyperv/utility: share status return values.

honzhan_microsoft.com updated this object.Oct 31 2016, 5:42 AM

honzhan_microsoft.com added reviewers: decui_microsoft.com, sepherosa_gmail.com, howard0su_gmail.com, hrs, royger, delphij.

honzhan_microsoft.com updated this revision to Diff 21869.Nov 1 2016, 6:38 AM

honzhan_microsoft.com updated this object.

sepherosa_gmail.com accepted this revision.Nov 1 2016, 6:39 AM

sepherosa_gmail.com edited edge metadata.

This revision is now accepted and ready to land.Nov 1 2016, 6:39 AM

Closed by commit rS308201: hyperv/kvp: Don't mix message status codes and function return values. (authored by sephe). · Explain WhyNov 2 2016, 7:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

contrib/

hyperv/

tools/

hv_kvp_daemon.c

34 lines

sys/

dev/

hyperv/

utilities/

	hv_common.h
	hv_utilreg.h

57 lines

14 lines

24 lines

15 lines

Diff 21822

contrib/hyperv/tools/hv_kvp_daemon.c

Loading...

sys/dev/hyperv/utilities/hv_common.h

Loading...

sys/dev/hyperv/utilities/hv_kvp.h

Loading...

sys/dev/hyperv/utilities/hv_kvp.c

Loading...

sys/dev/hyperv/utilities/hv_utilreg.h

Loading...