Page MenuHomeFreeBSD

Move MK_GDB condition out of MK_BINUTILS
ClosedPublic

Authored by emaste on Oct 19 2016, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 26, 12:24 AM
Unknown Object (File)
Thu, Sep 25, 8:06 AM
Unknown Object (File)
Thu, Sep 18, 11:35 PM
Unknown Object (File)
Sep 2 2025, 8:29 AM
Unknown Object (File)
Aug 29 2025, 2:31 PM
Unknown Object (File)
Aug 29 2025, 1:25 AM
Unknown Object (File)
Jul 31 2025, 2:29 PM
Unknown Object (File)
Jul 29 2025, 2:59 AM

Details

Summary

After rS307655 MK_GDB is forced to no if MK_BINUTILS == no, so we can simplify gnu/{lib,usr.bin}/Makefile to use only SUBDIR.${MK_GDB} without the compound condition.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to Move MK_GDB condition out of MK_BINUTILS.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: imp, marius.

Use the same logic to move MK_GROFF out, as MK_GROFF is forced to no if MK_CXX == no.

Rebase after rS307674. Note that D8298 would introduce a new compound condition that's not trivially simplified and maybe it's not worth doing this.

brooks added a reviewer: brooks.

Seems reasonable. I don't see binutils and gdb as particularly related.

This revision is now accepted and ready to land.Oct 20 2016, 5:14 PM
emaste added inline comments.
gnu/lib/Makefile
11 ↗(On Diff #21547)

This part addressed in rS317210 by @bapt

This revision was automatically updated to reflect the committed changes.