Page MenuHomeFreeBSD
Differential D8287

Move MK_GDB condition out of MK_BINUTILS
ClosedPublic
Actions

Authored by emaste on Oct 19 2016, 8:14 PM.
Tags
None
Referenced Files
F103158845: D8287.diff
Thu, Nov 21, 5:40 PM
F103147840: D8287.diff
Thu, Nov 21, 3:06 PM
Unknown Object (File)
Wed, Nov 20, 3:28 PM
Unknown Object (File)
Wed, Nov 20, 1:23 PM
Unknown Object (File)
Mon, Nov 18, 11:06 AM
Unknown Object (File)
Mon, Nov 11, 9:07 PM
Unknown Object (File)
Mon, Nov 11, 2:22 PM
Unknown Object (File)
Mon, Nov 11, 2:20 PM
View All 86 Files
Subscribers
bapt
bdrewery
brooks

Details

Reviewers
brooks
imp
marius
bapt
Commits
rS317252: Simplify gnu/usr.bin Makefile conditions
Summary

After rS307655 MK_GDB is forced to no if MK_BINUTILS == no, so we can simplify gnu/{lib,usr.bin}/Makefile to use only SUBDIR.${MK_GDB} without the compound condition.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 21509.Oct 19 2016, 8:14 PM
emaste retitled this revision from to Move MK_GDB condition out of MK_BINUTILS.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: imp, marius.
emaste updated this revision to Diff 21512.Oct 19 2016, 9:33 PM

Use the same logic to move MK_GROFF out, as MK_GROFF is forced to no if MK_CXX == no.

emaste added subscribers: brooks, bdrewery.Oct 20 2016, 12:54 AM
emaste updated this revision to Diff 21547.Oct 20 2016, 5:04 PM

Rebase after rS307674. Note that D8298 would introduce a new compound condition that's not trivially simplified and maybe it's not worth doing this.

brooks accepted this revision.Oct 20 2016, 5:14 PM
brooks added a reviewer: brooks.

Seems reasonable. I don't see binutils and gdb as particularly related.

This revision is now accepted and ready to land.Oct 20 2016, 5:14 PM
emaste added a subscriber: bapt.Apr 20 2017, 7:41 PM
emaste added inline comments.
gnu/lib/Makefile
11 ↗(On Diff #21547)

This part addressed in rS317210 by @bapt

bapt accepted this revision.Apr 20 2017, 7:44 PM
Closed by commit rS317252: Simplify gnu/usr.bin Makefile conditions (authored by emaste). · Explain WhyApr 21 2017, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
gnu/
usr.bin/
10 lines

Diff 27600

View Options

head/gnu/usr.bin/Makefile

Loading...