Move MK_GDB condition out of MK_BINUTILS
ClosedPublic
Actions

Authored by emaste on Oct 19 2016, 8:14 PM.

Details

Reviewers

brooks
imp
marius
bapt

Commits

rS317252: Simplify gnu/usr.bin Makefile conditions

Summary

After rS307655 MK_GDB is forced to no if MK_BINUTILS == no, so we can simplify gnu/{lib,usr.bin}/Makefile to use only SUBDIR.${MK_GDB} without the compound condition.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 21509.Oct 19 2016, 8:14 PM

emaste retitled this revision from to Move MK_GDB condition out of MK_BINUTILS.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: imp, marius.

Use the same logic to move MK_GROFF out, as MK_GROFF is forced to no if MK_CXX == no.

emaste added subscribers: brooks, bdrewery.Oct 20 2016, 12:54 AM

Rebase after rS307674. Note that D8298 would introduce a new compound condition that's not trivially simplified and maybe it's not worth doing this.

Seems reasonable. I don't see binutils and gdb as particularly related.

This revision is now accepted and ready to land.Oct 20 2016, 5:14 PM

emaste added a subscriber: bapt.Apr 20 2017, 7:41 PM

emaste added inline comments.

gnu/lib/Makefile
11 ↗	(On Diff #21547)	This part addressed in rS317210 by @bapt

bapt accepted this revision.Apr 20 2017, 7:44 PM

Closed by commit rS317252: Simplify gnu/usr.bin Makefile conditions (authored by emaste). · Explain WhyApr 21 2017, 1:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

gnu/

usr.bin/

Makefile

10 lines

Diff 27600

View Options

Move MK_GDB condition out of MK_BINUTILSClosedPublicActions