Page MenuHomeFreeBSD
Differential D8253

Cubic changes for improved loss recovery.
Needs ReviewPublic
Actions

Authored by hiren on Oct 14 2016, 6:49 PM.
Tags
None
Referenced Files
F156439527: D8253.id21399.diff
Wed, May 13, 5:22 PM
Unknown Object (File)
Mon, May 11, 12:04 AM
Unknown Object (File)
Thu, Apr 30, 6:52 PM
Unknown Object (File)
Wed, Apr 29, 6:03 PM
Unknown Object (File)
Thu, Apr 23, 5:52 AM
Unknown Object (File)
Wed, Apr 22, 6:50 PM
Unknown Object (File)
Mon, Apr 20, 1:24 AM
Unknown Object (File)
Thu, Apr 16, 3:00 AM
View All Files
Subscribers
kbowling
kmacy
melifaro
rscheff
transport

Details

Reviewers
rrs
lstewart
Group Reviewers
transport
Summary
  • always update t_last_cong on loss and generally treat first loss as valid
  • restore old t_last_cong on bad retransmit and generally undo first loss if not valid
  • add fast convergence (see 3.6 in RFC)
  • scale ssthresh by cubic beta rather than 0.5, per RFC (same as Linux)

Submitted by: Matt Macy
Sponsored by: Limelight Networks

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5610
Build 5875: arc lint + arc unit

Event Timeline

hiren updated this revision to Diff 21399.Oct 14 2016, 6:49 PM
hiren retitled this revision from to Cubic changes for improved loss recovery..
hiren updated this object.
hiren edited the test plan for this revision. (Show Details)
hiren added a subscriber: transport.
hiren added reviewers: rrs, lstewart.Oct 14 2016, 6:51 PM
hiren added a subscriber: kmacy.
kbowling added a subscriber: kbowling.Oct 14 2016, 9:16 PM
rscheff added a subscriber: rscheff.Feb 11 2019, 3:31 PM
rscheff added inline comments.Feb 11 2019, 8:16 PM
sys/netinet/cc/cc_cubic.c
444

need a typecast to (uint64_t) here for very large cwnd

474

Why introduce CUBIC_SCALE for a single use here, instead of (1<<CUBIC_SCALE)?

Also, this code doesn't seem to match the comment?

rscheff added a reviewer: transport.Aug 13 2020, 2:34 PM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptAug 13 2020, 2:34 PM
Herald added a subscriber: melifaro. · View Herald Transcript

Revision Contents
Changeset List

PathSize
sys/
netinet/
cc/
2 lines
81 lines

Diff 21399

View Options

sys/netinet/cc/cc_cubic.h

Loading...
View Options

sys/netinet/cc/cc_cubic.c

Loading...