Update Qt to 5.6.2

[adridg]

Summary

This updates Qt 5.6.1 to Qt 5.6.2 (both of them LTS). Original work by tcberner, adjusted to Qt 5.6.2 final by me.

Test Plan

Needs build of devel/qt5, devel/py-qt5 to get started; after that probably one or more of the bigger Qt5 consumers (qupzilla in particular).

[tcberner]

devel/qmake5/Makefile

55

I think this is no longer needed. mkspecs/unsupported/freebsd-g++46 no longer exists.

[tcberner]

misc/qt5-examples/Makefile

7

this should again be changed to official_releases =)

[mat]

If you can't use arcanist for some reason to upload your diffs, could you at least upload them the same way it does, with a lot of context (svn diff --diff-cmd=diff -x -U9999 or git diff -U9999)

[adridg]

misc/qt5-examples/Makefile

7

Also QT5_SUBDIR is not defined anywhere, so I've removed that.

[adridg]

Update Qt to 5.6.2 (v2)

• Addressed tcberner@'s comments
• This revision done with arc, per mat@'s comment

[tcberner]

misc/qt5-examples/Makefile

7–8

There seem to be spaces instead of tabs between on the MASTER_SITES= line.

[adridg]

Update Qt to 5.6.2 (v3)

Addressed tabs-vs-spaces in qt5-examples/Makefile

[rakuco]

The only thing I don't understand is why devel/qmake5/files/patch-mkspecs__features__qt_functions.prf was removed, as the code we were patching is still present upstream.

[adridg]

Update Qt to 5.6.2 (v4)

• Removed a now-empty directory
• Restored patch Rakuco pointed out as missing (thanks tcberner@)

[adridg]

Mark things as done that were resolved by v3 and v4 patches.

[rakuco]

looks good to me too. the next step is filing an exp-run request to test the patch

[emaste]

rP424842 says

Still Importing...
This commit is still importing. Changes will be visible once the import finishes.

[tcberner]

In D8228#175284, @emaste wrote:

rP424842 says

Still Importing...
This commit is still importing. Changes will be visible once the import finishes.

@emaste : Should we simply close it now? Or is there anything else to do?

[emaste]

Yes you can just close this review. The PR will track the Phabricator importer issue.

[tcberner]

Thanks :)

[tcberner]

Hm, it refuses to be closed

You can not close this revision because it has not been accepted. You can only close accepted revisions.

[emaste]

Let me try accepting again

[emaste]

Oh, I think it needs the 'blocking reviewers' to accept

[mat]

That's my cue.