Capsicumize soelim(1)
ClosedPublic
Actions

Authored by bapt on Sep 18 2016, 10:49 AM.

Details

Reviewers

emaste
cem
allanjude
oshogbo

Commits

rS305936: Capsicum-ize soelim(1).

Summary

Given it expects multiple files in arguments, open / first and then only
usr openat to open the various files.

In order to include files in the current directory we add it to the list of
includes in first argument

Test Plan

Passes the testsuite

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 20440.Sep 18 2016, 10:49 AM

bapt retitled this revision from to Capsicumize soelim(1).

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added reviewers: oshogbo, emaste, allanjude, cem.

Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 10:49 AM

Close the fd on / when exiting

Fix typo in error message

bapt mentioned this in D7918: ident(1): Capsicumify.Sep 18 2016, 12:24 PM

looks good to me. Might be able to be improved once casper has filesystem services

This revision is now accepted and ready to land.Sep 18 2016, 4:17 PM

Closed by commit rS305936: Capsicum-ize soelim(1). (authored by bapt). · Explain WhySep 18 2016, 4:25 PM

This revision was automatically updated to reflect the committed changes.

oshogbo added inline comments.Sep 18 2016, 5:51 PM

head/usr.bin/soelim/soelim.c
60	Style should be one free line if there is no variables.
78	Can fail.
89	Can fail.
159	getcwd - can fail.
197	Can fail.

oshogbo added inline comments.Sep 18 2016, 5:56 PM

head/usr.bin/soelim/soelim.c
187	Dot on the on of the comment ;P

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

soelim/

soelim.c

70 lines

Diff 20458

View Options

head/usr.bin/soelim/soelim.c

Capsicumize soelim(1)ClosedPublicActions