net-im/telepathy-qt4 and net-im/telepathy-qt5 had very similar Makefiles and
use the same distfile. So it makes sense to combine them into slaveports.
Details
Details
Tested in poudriere on 12-current (64), 10.3 (64) and 9.3 (32).
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 5460 Build 5672: arc lint + arc unit
Event Timeline
| head/net-im/telepathy-qt4/Makefile | ||
|---|---|---|
| 31 ↗ | (On Diff #21056) | This could have been expressed in a more declarative style e.g., # master OPTIONS_SLAVE?= QT4 QT4_USE= QT4=corelib,dbus,... QT4_PLIST_SUB= SHLIB_SUFFIX=2 QT5_USE= QT5=core,dbus,... QT5_PLIST_SUB= SHLIB_SUFFIX=0 # slave OPTIONS_SLAVE= QT5 |
| 58 ↗ | (On Diff #21056) | Breaking statu quo requires PORTREVISION bump: /doc suffix is gone while /usr added. $ svn up -r423331 $ make -V DOCSDIR /usr/local/share/doc/telepathy-qt4 $ svn up -r423332 $ make -V DOCSDIR /usr/local/usr/share/telepathy-qt4 |
| head/net-im/telepathy-qt5/Makefile | ||
| 3 ↗ | (On Diff #21056) | Why keep this line? Master port already defines PORTNAME. |
| head/net-im/telepathy-qt4/Makefile | ||
|---|---|---|
| 58 ↗ | (On Diff #21056) | Yikes. You're completely right. That is wrong. I'll provide a correct update as soon as I can. |
Comment Actions
- Correct the value of DOCSDIR, and
- remove redundant PORTNAME from telepathy-qt5/Makefile.