telepathy-qt4
ClosedPublic
Actions

Authored by tcberner on Sep 15 2016, 11:57 AM.

Details

Reviewers

rakuco
jbeich
mat

Commits

rP423337: net-im/telepathy-qt[45]: Fixup DOCSDIR, sipmlify -qt5
rP423332: Make net-im/telepathy-qt5 a slaveport of net-im/telepathy-qt4

Summary

net-im/telepathy-qt4 and net-im/telepathy-qt5 had very similar Makefiles and
use the same distfile. So it makes sense to combine them into slaveports.

Test Plan

Tested in poudriere on 12-current (64), 10.3 (64) and 9.3 (32).

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tcberner updated this revision to Diff 20366.Sep 15 2016, 11:57 AM

tcberner retitled this revision from to Make net-im/telepathy-qt5 a slaveport of net-im/telepathy-qt4.

tcberner updated this object.

tcberner edited the test plan for this revision. (Show Details)

tcberner added reviewers: rakuco, mat.

tcberner added a subscriber: adridg.

mat accepted this revision.Sep 15 2016, 3:17 PM

mat edited edge metadata.

This revision is now accepted and ready to land.Sep 15 2016, 3:17 PM

Closed by commit rP423332: Make net-im/telepathy-qt5 a slaveport of net-im/telepathy-qt4 (authored by tcberner). · Explain WhyOct 5 2016, 9:57 AM

This revision was automatically updated to reflect the committed changes.

jbeich added a subscriber: jbeich.Oct 5 2016, 10:44 AM

jbeich added inline comments.

head/net-im/telepathy-qt4/Makefile
32	This could have been expressed in a more declarative style e.g., # master OPTIONS_SLAVE?= QT4 QT4_USE= QT4=corelib,dbus,... QT4_PLIST_SUB= SHLIB_SUFFIX=2 QT5_USE= QT5=core,dbus,... QT5_PLIST_SUB= SHLIB_SUFFIX=0 # slave OPTIONS_SLAVE= QT5
59	Breaking statu quo requires `PORTREVISION` bump: `/doc` suffix is gone while `/usr` added. $ svn up -r423331 $ make -V DOCSDIR /usr/local/share/doc/telepathy-qt4 $ svn up -r423332 $ make -V DOCSDIR /usr/local/usr/share/telepathy-qt4
head/net-im/telepathy-qt5/Makefile
2–4	Why keep this line? Master port already defines `PORTNAME`.