Page MenuHomeFreeBSD

math/gsl: Repair math/gsl build to support ARMv6
ClosedPublic

Authored by sbruno on Sep 16 2014, 2:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 17 2024, 11:08 PM
Unknown Object (File)
Mar 17 2024, 11:08 PM
Unknown Object (File)
Mar 17 2024, 11:08 PM
Unknown Object (File)
Mar 17 2024, 11:08 PM
Unknown Object (File)
Mar 17 2024, 11:08 PM
Unknown Object (File)
Mar 17 2024, 11:08 PM
Unknown Object (File)
Mar 17 2024, 10:57 PM
Unknown Object (File)
Feb 18 2024, 11:29 PM
Subscribers

Details

Summary

This port uses x86 specific ASM to generate floating point function support. DTRT for ARMv6

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

sbruno retitled this revision from to math/gsl: Disable for ARM platforms due to missing ieeefp support.
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added reviewers: tijl, bapt, bdrewery.

hold on reviewing, I'll update in a bit. there might be a way to support this.

Actually, Nathan recognized the build failure and pointed me at the same spot
that was used to repair PPC to repair the ARM build failure. Amusing.

sbruno removed a reviewer: tijl.
sbruno added a subscriber: ARM.
sbruno retitled this revision from math/gsl: Disable for ARM platforms due to missing ieeefp support to math/gsl: Repair math/gsl build to support ARMv6.Sep 16 2014, 4:31 PM
sbruno updated this object.
rpaulo added inline comments.
math/gsl/files/patch-ieee-utils-fp-freebsd.c
0

How about changing the error string as well?

0

There are a bunch of mentions to powerpc in the error strings.

0

Again here.

Update error strings to be more generic instead of powerpc specific

Should we have #if !defined(i386) && !defined(amd64) instead of whitelisting powerpc and arm? The stuff not being included is very x87 specific. Or use the gnuc99 fenv support, which looks like it's MI?

sbruno edited edge metadata.

Even more better version from nathan.

Drop patch-ieee-utils-fp-freebsd.c alltogether and change the order
of #ifdefs in the setup to pull in fp-gnuc99.c instead of fp-freebsd.cc

needs a redports shake I think. It built here for 11-current amd64 locally.

I like the approach. It builds and works on powerpc64 11. It probably does need a test, but otherwise it looks good from my end.

bdrewery edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2014, 6:47 PM
nwhitehorn edited edge metadata.

Looks good. Thanks!

Committed at svn r368343.