log.
ClosedPublic
Actions

Authored by ed on Sep 8 2016, 8:26 PM.

Details

Reviewers

gjb
allanjude
ngie
bdrewery

Commits

rS305651: Properly patch up dirname()/basename() calls to not clobber ent->log.

Summary

It turns out that we had a couple of more calls to dirname()/basename()
in newsyslog(8) that assume the input isn't clobbered. This is bad,
because it apparently breaks log rotation now that the new dirname()
implementation has been merged.

Fix this by first copying the input and then calling
dirname()/basename(). While there, improve the naming of variables in
this function a bit.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed updated this revision to Diff 20212.Sep 8 2016, 8:26 PM

ed retitled this revision from to Properly patch up dirname()/basename() calls to not clobber ent->log..

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added reviewers: gjb, ngie.

Herald added a subscriber: imp. · View Herald TranscriptSep 8 2016, 8:26 PM

bdrewery accepted this revision.Sep 8 2016, 8:34 PM

bdrewery added a reviewer: bdrewery.

bdrewery added a subscriber: bdrewery.

bdrewery added inline comments.

usr.sbin/newsyslog/newsyslog.c
1535 ↗	(On Diff #20212)	I don't see a reason for this old strdup

This revision is now accepted and ready to land.Sep 8 2016, 8:34 PM

allanjude accepted this revision.Sep 8 2016, 8:47 PM

allanjude added a reviewer: allanjude.

Closed by commit rS305651: Properly patch up dirname()/basename() calls to not clobber ent->log. (authored by ed). · Explain WhySep 9 2016, 7:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

newsyslog/

newsyslog.c

32 lines

Diff 20222

View Options

head/usr.sbin/newsyslog/newsyslog.c

Properly patch up dirname()/basename() calls to not clobber ent->log.ClosedPublicActions