Page MenuHomeFreeBSD
Differential D7820

Reduce duplicate NOASM and PSEUDO definitions.
ClosedPublic
Actions

Authored by brooks on Sep 8 2016, 12:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 8:06 AM
Unknown Object (File)
Dec 13 2023, 11:56 AM
Unknown Object (File)
Oct 22 2023, 12:03 AM
Unknown Object (File)
Sep 24 2023, 12:51 PM
Unknown Object (File)
Aug 9 2023, 5:53 PM
Unknown Object (File)
Aug 9 2023, 5:48 PM
Unknown Object (File)
Aug 9 2023, 5:43 PM
Unknown Object (File)
Aug 9 2023, 5:42 PM
View All 30 Files
Subscribers
emaste
imp

Details

Reviewers
kib
jhb
andrew
Commits
rS305630: Reduce duplicate NOASM and PSEUDO definitions
Summary

The initial value of NOASM is nearly the same in all cases and the
initial value of PSEUDO is the same in all cases so reduce duplication
(and hopefully, future merge conflicts) by machine independent defaults.

Also document the PSEUDO variable.

Test Plan

A variant has been in CheriBSD for some time. Passes tinderbox.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks updated this revision to Diff 20159.Sep 8 2016, 12:43 AM
brooks retitled this revision from to Reduce duplicate NOASM and PSEUDO definitions..
brooks updated this object.
brooks edited the test plan for this revision. (Show Details)
brooks added reviewers: jhb, andrew, kib.
Herald added subscribers: emaste, imp. · View Herald TranscriptSep 8 2016, 12:43 AM
kib accepted this revision.Sep 8 2016, 8:48 AM
kib edited edge metadata.
kib added inline comments.
lib/libc/sys/Makefile.inc
15 ↗(On Diff #20159)

s/code/symbols/

This revision is now accepted and ready to land.Sep 8 2016, 8:48 AM
brooks updated this revision to Diff 20200.Sep 8 2016, 4:05 PM
brooks edited edge metadata.
  • Adjust comment per kib's suggestion.
This revision now requires review to proceed.Sep 8 2016, 4:05 PM
jhb accepted this revision.Sep 8 2016, 7:37 PM
jhb edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2016, 7:37 PM
brooks marked an inline comment as done.Sep 8 2016, 10:37 PM
Closed by commit rS305630: Reduce duplicate NOASM and PSEUDO definitions (authored by brooks). · Explain WhySep 8 2016, 10:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
aarch64/
sys/
12 lines
amd64/
sys/
4 lines
arm/
sys/
4 lines
i386/
sys/
5 lines
mips/
sys/
4 lines
powerpc/
sys/
5 lines
powerpc64/
sys/
5 lines
riscv/
sys/
11 lines
sparc64/
sys/
5 lines
sys/
11 lines

Diff 20215

View Options

head/lib/libc/aarch64/sys/Makefile.inc

Loading...
View Options

head/lib/libc/amd64/sys/Makefile.inc

Loading...
View Options

head/lib/libc/arm/sys/Makefile.inc

Loading...
View Options

head/lib/libc/i386/sys/Makefile.inc

Loading...
View Options

head/lib/libc/mips/sys/Makefile.inc

Loading...
View Options

head/lib/libc/powerpc/sys/Makefile.inc

Loading...
View Options

head/lib/libc/powerpc64/sys/Makefile.inc

Loading...
View Options

head/lib/libc/riscv/sys/Makefile.inc

Loading...
View Options

head/lib/libc/sparc64/sys/Makefile.inc

Loading...
View Options

head/lib/libc/sys/Makefile.inc

Loading...