Page MenuHomeFreeBSD

bspatch: clean up output file in the case of error
ClosedPublic

Authored by emaste on Aug 25 2016, 6:47 PM.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste retitled this revision from to bspatch: clean up output file in the case of error.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: allanjude, oshogbo, cperciva, delphij.

unlinkat is POSIX so no need to use it only in the #ifdef CAPSICUM case

usr.bin/bsdiff/bspatch/bspatch.c
153

bonus whitespace fix

Some comments.

usr.bin/bsdiff/bspatch/bspatch.c
58

Blank space needed.

132

This can fail right?

133

dirname, can return NULL.

136

This can fail.

usr.bin/bsdiff/bspatch/bspatch.c
134

namebuf can be NULL. Should we print argv[2]?

usr.bin/bsdiff/bspatch/bspatch.c
134

Sorry for being PITA but namebuf still can be NULL, in this err msg.

oshogbo edited edge metadata.

Thank you for doing this.

This revision is now accepted and ready to land.Aug 25 2016, 8:48 PM
This revision was automatically updated to reflect the committed changes.