Page MenuHomeFreeBSD
Differential D7644

bspatch: clean up output file in the case of error
ClosedPublic
Actions

Authored by emaste on Aug 25 2016, 6:47 PM.
Tags
None
Referenced Files
F103265412: D7644.id19693.diff
Fri, Nov 22, 8:03 PM
Unknown Object (File)
Sun, Nov 10, 8:03 AM
Unknown Object (File)
Fri, Nov 8, 10:04 AM
Unknown Object (File)
Oct 23 2024, 2:58 PM
Unknown Object (File)
Sep 28 2024, 10:58 PM
Unknown Object (File)
Sep 27 2024, 3:24 PM
Unknown Object (File)
Sep 26 2024, 9:58 PM
Unknown Object (File)
Sep 24 2024, 9:15 AM
View All Files
Subscribers
None

Details

Reviewers
allanjude
delphij
cperciva
oshogbo
Commits
rS304821: bspatch: remove output file in the case of error

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 19683.Aug 25 2016, 6:47 PM
emaste retitled this revision from to bspatch: clean up output file in the case of error.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: allanjude, oshogbo, cperciva, delphij.
emaste updated this revision to Diff 19686.Aug 25 2016, 7:14 PM

unlinkat is POSIX so no need to use it only in the #ifdef CAPSICUM case

usr.bin/bsdiff/bspatch/bspatch.c
153 ↗(On Diff #19686)

bonus whitespace fix

oshogbo edited edge metadata.Aug 25 2016, 7:59 PM

Some comments.

usr.bin/bsdiff/bspatch/bspatch.c
58 ↗(On Diff #19686)

Blank space needed.

132 ↗(On Diff #19686)

This can fail right?

133 ↗(On Diff #19686)

dirname, can return NULL.

136 ↗(On Diff #19686)

This can fail.

emaste updated this revision to Diff 19690.Aug 25 2016, 8:35 PM
emaste edited edge metadata.

fixups from @oshogbo

oshogbo added inline comments.Aug 25 2016, 8:41 PM
usr.bin/bsdiff/bspatch/bspatch.c
136 ↗(On Diff #19690)

namebuf can be NULL. Should we print argv[2]?

emaste updated this revision to Diff 19691.Aug 25 2016, 8:44 PM

add strdup failure check

emaste updated this revision to Diff 19692.Aug 25 2016, 8:47 PM

one more fix from @oshogbo

oshogbo added inline comments.Aug 25 2016, 8:47 PM
usr.bin/bsdiff/bspatch/bspatch.c
136 ↗(On Diff #19690)

Sorry for being PITA but namebuf still can be NULL, in this err msg.

oshogbo accepted this revision.Aug 25 2016, 8:48 PM
oshogbo edited edge metadata.

Thank you for doing this.

This revision is now accepted and ready to land.Aug 25 2016, 8:48 PM
Closed by commit rS304821: bspatch: remove output file in the case of error (authored by emaste). · Explain WhyAug 25 2016, 9:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
bsdiff/
bspatch/
37 lines

Diff 19693

View Options

head/usr.bin/bsdiff/bspatch/bspatch.c

Loading...