Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointer
ClosedPublic
Actions

Authored by tsoome on Aug 24 2016, 3:31 PM.

Details

Reviewers

allanjude
imp

Commits

rS304753: Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointer

Summary

During the disks probing to discover the zfs pools, the loader will attempt to read the pool label with NULL (uninitialized) spa. The normal loader operations do hide the issue, but userboot did reveal it by crashing bhyveload.

Test Plan

bhyveload should operate without crash.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome updated this revision to Diff 19639.Aug 24 2016, 3:31 PM

tsoome retitled this revision from to Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointer.

tsoome updated this object.

tsoome edited the test plan for this revision. (Show Details)

tsoome added reviewers: allanjude, imp.

Herald added a subscriber: delphij. · View Herald TranscriptAug 24 2016, 3:31 PM

Approved for commit

This revision is now accepted and ready to land.Aug 24 2016, 3:45 PM

With D7634 and D7635 applied I can boot my root on ZFS bhyves again. Thanks.

flo mentioned this in D7635: Bug 212038 - svn commit: r304321 broken bhyve zvol VM bhyveload hang 100% WCPU.Aug 24 2016, 4:02 PM

Closed by commit rS304753: Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointer (authored by tsoome). · Explain WhyAug 24 2016, 4:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

boot/

zfs/

zfssubr.c

13 lines

Diff 19647

View Options

head/sys/cddl/boot/zfs/zfssubr.c

Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointerClosedPublicActions