Page MenuHomeFreeBSD

Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointer
ClosedPublic

Authored by tsoome on Aug 24 2016, 3:31 PM.

Details

Summary

During the disks probing to discover the zfs pools, the loader will attempt to read the pool label with NULL (uninitialized) spa. The normal loader operations do hide the issue, but userboot did reveal it by crashing bhyveload.

Test Plan

bhyveload should operate without crash.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tsoome retitled this revision from to Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointer.Aug 24 2016, 3:31 PM
tsoome updated this object.
tsoome edited the test plan for this revision. (Show Details)
tsoome added reviewers: allanjude, imp.
tsoome updated this revision to Diff 19639.
allanjude edited edge metadata.Aug 24 2016, 3:45 PM
allanjude accepted this revision.

Approved for commit

This revision is now accepted and ready to land.Aug 24 2016, 3:45 PM
flo added a subscriber: flo.Aug 24 2016, 4:01 PM

With D7634 and D7635 applied I can boot my root on ZFS bhyves again. Thanks.

This revision was automatically updated to reflect the committed changes.