Page MenuHomeFreeBSD

Remove tests for non-standard behaviour of dirname(3)/basename(3).
ClosedPublic

Authored by ed on Aug 15 2016, 6:04 PM.

Details

Summary

The NetBSD ATF tests explicitly check that these functions do not modify
their input. These tests are NetBSD-specific. They test for something
that is not part of POSIX.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4798
Build 4854: arc lint + arc unit

Event Timeline

ed retitled this revision from to Remove tests for non-standard behaviour of dirname(3)/basename(3)..
ed updated this object.
ed edited the test plan for this revision. (Show Details)
ed added a reviewer: ngie.

This seems like it deserves a manpage update under CAVEATS.

contrib/netbsd-tests/lib/libc/gen/t_basedirname.c
114

Please add #ifdef __NetBSD__ instead to reduce the diff with upstream.

165

Same as above.

ed edited edge metadata.

Simplify patch against upstream by ifdef'ing the affected code instead.

This revision was automatically updated to reflect the committed changes.
In D7506#155968, @ed wrote:

Simplify patch against upstream by ifdef'ing the affected code instead.

Thank you :)!