Remove tests for non-standard behaviour of dirname(3)/basename(3).
ClosedPublic
Actions

Authored by ed on Aug 15 2016, 6:04 PM.

Details

Reviewers

ngie

Commits

rS304175: Disable tests for non-standard behaviour of dirname(3)/basename(3).

Summary

The NetBSD ATF tests explicitly check that these functions do not modify
their input. These tests are NetBSD-specific. They test for something
that is not part of POSIX.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed updated this revision to Diff 19297.Aug 15 2016, 6:04 PM

ed retitled this revision from to Remove tests for non-standard behaviour of dirname(3)/basename(3)..

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added a reviewer: ngie.

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2016, 6:04 PM

This seems like it deserves a manpage update under CAVEATS.

contrib/netbsd-tests/lib/libc/gen/t_basedirname.c
114 ↗	(On Diff #19297)	Please add `#ifdef __NetBSD__` instead to reduce the diff with upstream.
165 ↗	(On Diff #19297)	Same as above.

Simplify patch against upstream by ifdef'ing the affected code instead.

Closed by commit rS304175: Disable tests for non-standard behaviour of dirname(3)/basename(3). (authored by ed). · Explain WhyAug 15 2016, 7:05 PM

This revision was automatically updated to reflect the committed changes.

In D7506#155968, @ed wrote:

Simplify patch against upstream by ifdef'ing the affected code instead.

Thank you :)!

Revision Contents
Changeset List

Path

Size

head/

contrib/

netbsd-tests/

lib/

libc/

gen/

t_basedirname.c

4 lines

Diff 19300

View Options

head/contrib/netbsd-tests/lib/libc/gen/t_basedirname.c

Remove tests for non-standard behaviour of dirname(3)/basename(3).ClosedPublicActions