tcp/lro: Make # of LRO entries tunable
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 15 2016, 2:13 AM.

Tags

None

Referenced Files

	F153397500: D7499.id19319.vs19270.diff
	Mon, Apr 20, 10:26 PM

	F153317964: D7499.id19319.vs19270.diff
	Mon, Apr 20, 11:03 AM

	F153317913: D7499.id19319.vs19270.diff
	Mon, Apr 20, 11:02 AM

	Unknown Object (File)
	Wed, Apr 15, 9:23 PM

	Unknown Object (File)
	Wed, Apr 15, 2:17 PM

	Unknown Object (File)
	Mon, Apr 6, 12:56 PM

	Unknown Object (File)
	Thu, Mar 26, 6:49 AM

	Unknown Object (File)
	Thu, Mar 26, 2:25 AM

View All Files

Subscribers

freebsd-net-list

Details

Reviewers

gallatin
• hselasky
np
rrs

Group Reviewers

transport

Commits

rS304202: tcp/lro: Make # of LRO entries tunable

Summary

Obtained from: rrs, gallatin

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 19270.Aug 15 2016, 2:13 AM

sepherosa_gmail.com retitled this revision from to tcp/lro: Make # of LRO entries tunable.

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: rrs, gallatin, • hselasky, np.

sepherosa_gmail.com added a subscriber: freebsd-net-list.

Herald added a reviewer: transport. · View Herald TranscriptAug 15 2016, 2:13 AM

• hselasky added inline comments.Aug 15 2016, 7:30 AM

sys/netinet/tcp_lro.c
79 ↗	(On Diff #19270)	Maybe you should use a procedure type and range check the argument.

• hselasky accepted this revision.Aug 15 2016, 7:30 AM

• hselasky edited edge metadata.

I tend to think type / range checking something like this is overkill.. I'm OK with it as-is..

Closed by commit rS304202: tcp/lro: Make # of LRO entries tunable (authored by sephe). · Explain WhyAug 16 2016, 6:40 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_lro.c

12 lines

Diff 19319

View Options

head/sys/netinet/tcp_lro.c

tcp/lro: Make # of LRO entries tunableClosedPublicActions