Page MenuHomeFreeBSD
Differential D741

iscsi(4)
ClosedPublic
Actions

Authored by allanjude on Sep 8 2014, 9:07 AM.
Tags
None
Referenced Files
F108174037: D741.diff
Wed, Jan 22, 5:42 AM
Unknown Object (File)
Fri, Jan 10, 5:50 PM
Unknown Object (File)
Wed, Jan 8, 5:53 PM
Unknown Object (File)
Tue, Jan 7, 12:07 AM
Unknown Object (File)
Fri, Jan 3, 8:02 PM
Unknown Object (File)
Tue, Dec 31, 9:20 PM
Unknown Object (File)
Mon, Dec 30, 12:23 AM
Unknown Object (File)
Dec 14 2024, 9:53 PM
View All Files
Subscribers
allanjude
bcr
wblock

Details

Reviewers
eadler
trasz
wblock
bcr
Group Reviewers
Doc Committers
Summary

Add iscsi(4) manual page.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

trasz updated this revision to Diff 1398.Sep 8 2014, 9:07 AM
trasz retitled this revision from to iscsi(4).
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
trasz added a reviewer: Doc Committers.
allanjude added a subscriber: allanjude.Sep 8 2014, 5:25 PM
allanjude added inline comments.
share/man/man4/iscsi.4
61

This is the same variable as above, is it supposed to be different? should this be iscsid_timeout ?

I don't see login_timeout documented either

allanjude added a comment.Sep 8 2014, 5:37 PM

Proposed improvements: https://reviews.freebsd.org/differential/diff/1403/

allanjude commandeered this revision.Sep 8 2014, 6:21 PM
allanjude added a reviewer: trasz.

Taking over this differential to add my changes

allanjude updated this revision to Diff 1404.Sep 8 2014, 6:22 PM

Add missing sysctls
Improve language
Improve description

bcr added a subscriber: bcr.Sep 11 2014, 8:58 PM

I've found a typo. \o/

share/man/man4/iscsi.4
51

connecTs

wblock added a subscriber: wblock.Sep 11 2014, 9:50 PM
wblock added inline comments.
share/man/man4/iscsi.4
35

s/your/the/

70

"Specify" is unnecessary in this entry and the following ones.

89

US spelling: behavior

"gets dropped" is weird. Suggestion: "...has been dropped due to network problems."

91

Active, not passive: s/will cause/causes/

94

s/default/default,/

Break the compound sentence into simpler individual sentences:
By default, the device nodes are left intact. While the connection is down, all input/output operations are suspended, to be retried after the connection is reestablished.

allanjude updated this revision to Diff 1586.Sep 12 2014, 12:03 AM

Update man page with fixes from bcr@ and wblock@ as well as other minor improvements

allanjude updated this revision to Diff 1587.Sep 12 2014, 12:48 AM

Update the two other man pages to include the newer date
Also corrected a contraction and improve the sentence

allanjude added reviewers: wblock, bcr, eadler.Sep 12 2014, 12:49 AM
allanjude updated this revision to Diff 1588.Sep 12 2014, 12:54 AM

Update all files

allanjude updated this revision to Diff 1589.Sep 12 2014, 1:17 AM

Fix a typo

bcr accepted this revision.Sep 12 2014, 10:18 AM
bcr edited edge metadata.
This revision is now accepted and ready to land.Sep 12 2014, 10:18 AM
wblock added inline comments.Sep 12 2014, 1:08 PM
usr.sbin/iscsid/iscsid.8
54

Typo: "that is needs". Rearrange: All needed information is supplied by the kernel.

59

s/damon/daemon/

allanjude updated this revision to Diff 1603.Sep 13 2014, 12:20 AM
allanjude edited edge metadata.

Final update

allanjude updated this revision to Diff 1604.Sep 13 2014, 1:05 AM

Minor updates to the Author text

wblock accepted this revision.Sep 13 2014, 6:31 PM
wblock edited edge metadata.
allanjude closed this revision.Sep 13 2014, 6:40 PM

Committed as rS271543

Revision Contents
Changeset List

PathSize
share/
man/
man4/
1 line
94 lines
usr.bin/
iscsictl/
1 line
usr.sbin/
iscsid/
1 line

Diff 1398

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/iscsi.4

Loading...
View Options

usr.bin/iscsictl/iscsictl.8

Loading...
View Options

usr.sbin/iscsid/iscsid.8

Loading...