Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| Makefile.inc1 | ||
|---|---|---|
| 1240–1241 | What branch are you on? Keep these in syncMINIMUM_SUPPORTED_OSREL?= 900044 @echo "ERROR: Source upgrades from versions prior to ${MINIMUM_SUPPORTED_REL} are not supported."; \
false.endif | |
| Makefile.inc1 | ||
|---|---|---|
| 1240–1241 | It looks like it's an MFC of an earlier change on HEAD. I'm guessing to 10? The motivation is probably removing the __WITH_GETLINE check. | |
It looks like it's an MFC of an earlier change on HEAD. I'm guessing to 10? The motivation is probably removing the __WITH_GETLINE check.
Yeah, sorry I missed that, this is a merge to stable/10, specifically for the __WITH_GETLINE check. I don't want to sync it all the way up to what's in HEAD because it's reasonable to have an older minimum version in 10.
I kinda like it, but I know that Juniper put a ton of work into keeping 10 building from 7 for their own internal reasons. Unless that's been broken, it may be best to just abandon these changes.
| Makefile.inc1 | ||
|---|---|---|
| 1240–1241 | Do versions prior to 8 actually fail? Since this is a -stable branch, I'd be loathe to remove that support unless it's known to be broken. | |
| tools/build/Makefile | ||
| 12–23 | Love it. This change was fairly recent (only 2 years ago), but was necessary to continue building from 7 and earlier. So absent the ability to actually build from 7 (see above), this is fine to remove. If 10 still builds from 7, however, please abandon this entire rev because Juniper worked hard to make that happen and keep it working. | |
Yes, for stable/10 we do. However, for stable/11 and above, we require something newer (currently using 10.x) as we don't want to build clang for 7.x.