Page MenuHomeFreeBSD

Permit the name of the /dev/iov entry to be set by the driver.
ClosedPublic

Authored by jhb on Aug 2 2016, 10:31 PM.
Tags
None
Referenced Files
F109260726: D7400.diff
Sun, Feb 2, 5:57 PM
Unknown Object (File)
Dec 10 2024, 2:53 AM
Unknown Object (File)
Nov 21 2024, 4:46 PM
Unknown Object (File)
Nov 21 2024, 10:22 AM
Unknown Object (File)
Nov 21 2024, 10:20 AM
Unknown Object (File)
Oct 26 2024, 1:02 AM
Unknown Object (File)
Oct 19 2024, 12:28 PM
Unknown Object (File)
Sep 30 2024, 5:57 AM
Subscribers

Details

Summary

Permit the name of the /dev/iov entry to be set by the driver.

The PCI_IOV option creates character devices in /dev/iov for each PF
device driver that registers support for creating VFs. By default the
character device is named after the PF device (e.g. /dev/iov/foo0).
This change adds a variant of pci_iov_attach() called pci_iov_attach_name()
that allows the name of the /dev/iov entry to be specified by the
driver.

Test Plan
  • tested chelsio PF driver with pci_iov_attach first and then changed it to specify an alternate name
  • The manpages for iovctl(8) and iovctl.conf(5) manpages may need changes related to the "device" attribute.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4688
Build 4742: arc lint + arc unit

Event Timeline

jhb retitled this revision from to Permit the name of the /dev/iov entry to be set by the driver..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: rstone.
jhb added a subscriber: np.
rstone requested changes to this revision.Aug 3 2016, 3:24 PM
rstone edited edge metadata.
rstone added inline comments.
sys/dev/pci/pci_iov.h
37

Should declare this as __printf_like() so cc will error on bad format strings

43

will coverity or related tools start whining about passing a non-literal as the format string?

This revision now requires changes to proceed.Aug 3 2016, 3:24 PM
jhb marked an inline comment as done.Aug 3 2016, 4:03 PM
jhb added inline comments.
sys/dev/pci/pci_iov.h
43

Not in this case as the kobj method just accepts a 'const char *', not var args. Only the pciv_attach_name() wrapper accepts var args.

jhb edited edge metadata.
  • Add __printflike().
rstone edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2016, 5:03 PM
This revision was automatically updated to reflect the committed changes.