Page MenuHomeFreeBSD

benchmarks/sysbench: upgrade to sysbench-0.5
ClosedPublic

Authored by sam_samgwydir.com on Aug 1 2016, 8:42 PM.

Details

Summary

Update the sysbench port to build from https://github.com/akopytov/sysbench . Tests are now written in lua and the port has been updated to reflect that.

Test Plan

Test inside poudriere

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sam_samgwydir.com retitled this revision from to benchmarks/sysbench: upgrade to sysbench-0.5.
sam_samgwydir.com updated this object.
sam_samgwydir.com edited the test plan for this revision. (Show Details)
sam_samgwydir.com set the repository for this revision to rP FreeBSD ports repository.

The original sysbench author promised an updated release but may have abandoned the project. Percona has forked it for their purposes. Other suggestions in this situation?

Makefile
16 ↗(On Diff #18944)

This is the default and should be removed.

36 ↗(On Diff #18944)

Remove && cd - ?

Also, isn't autogen.sh doing about the same thing as USES=autoreconf ?

42 ↗(On Diff #18944)

Does this have to be pre-install ? if it is not needed for do-install to work, it should be post-install.

44 ↗(On Diff #18944)

Don't use cp -r, use the COPYTREE_* macros.

https://www.freebsd.org/doc/en/books/porters-handbook/install.html

sam_samgwydir.com removed rP FreeBSD ports repository as the repository for this revision.

updated according to mat's feedback.

Moved from pre-install to post-install.

When creating the pkg-plist file, best to run make makeplist

pkg-plist
72 ↗(On Diff #19014)

This is not needed.

73 ↗(On Diff #19014)

There's an empty line here.

Any more changes needed? If not, what is the next step here?

If there aren't anymore changes needed, what is the best way to get in touch with a ports committer?

mat, is this something you can commit?

Is there a PR for this?

Hmmm.... I can't seem to apply this patch to my ports tree.

lucid-nonsense:~...ports/benchmarks/sysbench:% arc patch D7388
A         files
Exception
Command failed with error #1!
COMMAND
(cd '/home/matthew/work/ports/' && mkdir 'files')

STDOUT
(empty)

STDERR
mkdir: files: File exists

(Run with `--trace` for a full exception trace.)

Having plumbed the mysteries of 'Download Raw Diff' I can run test builds. Seems all of mat's points have been addressed. Looks good to me

This revision is now accepted and ready to land.May 23 2017, 3:57 PM
This revision was automatically updated to reflect the committed changes.

I've checked the upstream and found that 1.0.7 is released. Would you please update the patch to the latest release? Thanks!

BTW, do you want to take maintainership?

Makefile
16 ↗(On Diff #19022)

GH_TAGNAME can be removed if you update it to 1.0.7.

files/patch-autogen.sh
5 ↗(On Diff #19022)

I would suggest using USES=shebangfix and bash_CMD=/bin/sh instead.

Upgrading to the 1.0 branch is non-trivial -- I'll take another crack at it if I have time.

Nevermind. I've updated it to 1.0.7 in r441740. :)