Page MenuHomeFreeBSD

Import libssp from NetBSD
AbandonedPublic

Authored by bapt on Jul 31 2016, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 15, 4:40 AM
Unknown Object (File)
Mon, Oct 7, 4:27 AM
Unknown Object (File)
Sep 27 2024, 8:35 PM
Unknown Object (File)
Sep 20 2024, 2:25 PM
Unknown Object (File)
Sep 7 2024, 12:36 PM
Unknown Object (File)
Aug 11 2024, 6:24 AM
Unknown Object (File)
Aug 4 2024, 1:26 PM
Unknown Object (File)
Jul 26 2024, 10:36 AM

Details

Reviewers
emaste
kan
jlh
pfg
Summary

Replace our GNU libssp with the NetBSD libssp (BSD licensed)
The library has been versionned the same way we versionned the GNU libssp

Integrate libssp the exact same way GNU libssp was integrated to ease import and
compatibility

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4673
Build 4727: arc lint + arc unit

Event Timeline

bapt retitled this revision from to Import libssp from NetBSD.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)

The modification on NetBSD libssp are: replacing dead with dead2 and adding some __unused I plan to upstream

pfg requested changes to this revision.Jul 31 2016, 11:21 PM
pfg edited edge metadata.

No, no, no ... please do *not do this.

NetBSD's libssp is a minomer for two things:

  1. The support for the stack protector: We already have that in lib/libc/secure/.
  2. Support for FORTIFY_SOURCE: This was almost finished for GSoC 2015 but is now abandoned.

FORTIFY_SOURCE doesn't have anything to do with the stack protector, the NetBSD guys just didn't think of a better place to put it. It does happen that the "strong" stack protector catches most of the issues that FORTIFY_SOURCE was meant to catch.
The NetBSD FORTIFY_SUPPORT stuff is also very outdated and doesn't support clang at all.

Hmm ... we have to investigate exactly what the libssp included in GCC does. It maybe that it is something very basic to support the stack protector, or it something that is not used at all.

This revision now requires changes to proceed.Jul 31 2016, 11:21 PM