Page MenuHomeFreeBSD
Differential D7333

hyperv/vmbus: Avoid unnecessary mb()
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jul 27 2016, 8:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 28, 8:27 PM
Unknown Object (File)
Mon, Jul 28, 7:39 AM
Unknown Object (File)
Tue, Jul 22, 1:27 PM
Unknown Object (File)
Mon, Jul 14, 9:53 AM
Unknown Object (File)
Sun, Jul 6, 8:19 AM
Unknown Object (File)
Sat, Jul 5, 5:33 AM
Unknown Object (File)
Fri, Jul 4, 5:46 PM
Unknown Object (File)
Fri, Jul 4, 10:13 AM
View All 92 Files
Subscribers
None

Details

Reviewers
kib
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
Commits
rS303421: hyperv/vmbus: Avoid unnecessary mb()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 18799.Jul 27 2016, 8:38 AM
sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Avoid unnecessary mb().
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: delphij, royger, kib, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
kib edited edge metadata.Jul 27 2016, 9:41 AM

How is this supposed to be reviewed ? Indeed, the patch changes compiler barrier + some fences into compiler barrier. Bit I have no idea why the change is safe, and what is the reason behind original code and this weaker variation.

Are you relying on the IA32 ordering guarantees ? If yes, then atomic_fence_acq() for read/any and atomic_fence_rel for any/write fencing is more clean.

sepherosa_gmail.com added a comment.Jul 27 2016, 9:47 AM
In D7333#152520, @kib wrote:

How is this supposed to be reviewed ? Indeed, the patch changes compiler barrier + some fences into compiler barrier. Bit I have no idea why the change is safe, and what is the reason behind original code and this weaker variation.

Are you relying on the IA32 ordering guarantees ? If yes, then atomic_fence_acq() for read/any and atomic_fence_rel for any/write fencing is more clean.

Yeah, I am relying on IA32 ordering. Well, since the other side is in the hypervisor, I am not sure about whether fence_acq and fence_rel will be more readable or not (since acq and rel will not be paired).

Closed by commit rS303421: hyperv/vmbus: Avoid unnecessary mb() (authored by sephe). · Explain WhyJul 28 2016, 6:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
vmbus/
20 lines

Diff 18836

View Options

head/sys/dev/hyperv/vmbus/vmbus_br.c

Loading...