Fix per-connection L2 caching in fast path
ClosedPublic
Actions

Authored by karels on Jul 19 2016, 1:46 AM.

Details

Reviewers

kmacy
gallatin
gnn

Group Reviewers

transport

Commits

rS303698: MFC r303171: Fix per-connection L2 caching in fast path
rS303171: Fix per-connection L2 caching in fast path

Summary

r301217 re-added per-connection L2 caching from a previous change,
but it omitted caching in the fast path. Add it.

Test Plan

tested with kernel debugger

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

karels updated this revision to Diff 18528.Jul 19 2016, 1:46 AM

karels retitled this revision from to Fix per-connection L2 caching in fast path.

karels updated this object.

karels edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptJul 19 2016, 1:46 AM

karels added reviewers: gnn, gallatin, kmacy, transport.Jul 19 2016, 1:51 AM

The code looks good to me; thanks for noticing that this was not in place.

Also, I've run this for 24+ hours on a box at Netflix serving roughly 100K connections and haven't seen any problems.

This revision is now accepted and ready to land.Jul 20 2016, 4:20 PM

Closed by commit rS303171: Fix per-connection L2 caching in fast path (authored by karels). · Explain WhyJul 22 2016, 2:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

if_ether.c

9 lines

netinet6/

nd6.c

11 lines

Diff 18649

View Options

head/sys/netinet/if_ether.c