audio/cplay: Update to 1.50
- Switch to GH account used by Debian
- Update patch-cplay to remove upstreamed changes and add mpv support
Release notes: https://github.com/hukka/cplay/blob/v1.50/ChangeLog
Details
Details
- Reviewers
adamw koobs mat - Commits
- rP419523: audio/cplay: Update to 1.50
poudriere testport audio/cplay
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 4494 Build 4545: arc lint + arc unit
Event Timeline
| audio/cplay/Makefile | ||
|---|---|---|
| 18 | See this message from koobs about python:2. Do you want python:2.7+ here? | |
| audio/cplay/Makefile | ||
|---|---|---|
| 18 | Fair question. However this software is not on PyPI and gives no details as to what python versions are supported. The changelog last discussed python support when they added python 2.0 support, and removed python 1.5 support (no mention of if python 1.6 is still supported, which it once was). Koobs: thoughts? | |
Comment Actions
Maybe you could add non default options to add RUN_DEPENDS on the various audio players ?
Comment Actions
As per suggestion from mat, add off-by-default runtime dependency options
for supported audio players.
| audio/cplay/Makefile | ||
|---|---|---|
| 18 | Looks like the cplay-ng[1] package forked to add features including Python 3 support You want USES=python:-2.7 | |
Comment Actions
If it depends on the python2 symlink, either shebangfix it, or add an explicit RUN_DEPENDS on lang/python2 because both :-2.7 *and* :2 can't be set at the same time iirc
Comment Actions
- Change to USES=python:-2.7 (thanks for advice from koobs, indeed testing with python3 failed)
- shebangfix need for python symlink (thanks for advice from koobs)
- Fix build of French translation (new patch)
Comment Actions
Lgtm, commit log message needs updating to reflect all changes and rationale (if necessary)