Add explicit detection of KVM hypervisor
ClosedPublic
Actions

Authored by badger on Jul 10 2016, 7:06 PM.

Details

Reviewers

kib
alc
vangyzen

Commits

rS302783: Add explicit detection of KVM hypervisor

Summary

Add explicit detection of KVM hypervisor

Set vm_guest to a new enum value (VM_GUEST_KVM) when kvm is detected and
use vm_guest in conditionals testing for KVM.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4484
Build 4535: arc lint + arc unit

Event Timeline

badger updated this revision to Diff 18252.Jul 10 2016, 7:06 PM

badger retitled this revision from to Add explicit detection of KVM hypervisor.

badger updated this object.

badger edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptJul 10 2016, 7:06 PM

badger added reviewers: vangyzen, kib.Jul 10 2016, 7:30 PM

kib accepted this revision.Jul 10 2016, 7:34 PM

kib edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2016, 7:34 PM

On line 797 of sys/amd64/amd64/pmap.c, we currently test vm_guest == VM_GUEST_VM. Should we test for != VM_GUEST_NO instead? That code seems to apply to all hypervisors. (Ditto for the i386 equivalent.)

In D7172#149441, @vangyzen wrote:

On line 797 of sys/amd64/amd64/pmap.c, we currently test vm_guest == VM_GUEST_VM. Should we test for != VM_GUEST_NO instead? That code seems to apply to all hypervisors. (Ditto for the i386 equivalent.)

Good catch. Reading through the commit message, that certainly seems to be the intent.